Re: [Emacs-diffs] master 3f06795: Migrate auth-source to cl-lib

Re: [Emacs-diffs] master 3f06795: Migrate auth-source to cl-lib

[Stefan Monnier]

> +(eval-when-compile
> +  (require 'cl-lib)
> +  (require 'eieio))

AFAIK eieio's macros always end up returning code which depends on eieio
functions, so a compile-time only `require` of eieio doesn't make
much sense.


        Stefan

Re: [Emacs-diffs] master 3f06795: Migrate auth-source to cl-lib

[Mark Oteiza]

On 02/11/16 at 04:06pm, Stefan Monnier wrote:
> > +(eval-when-compile
> > +  (require 'cl-lib)
> > +  (require 'eieio))
> 
> AFAIK eieio's macros always end up returning code which depends on eieio
> functions, so a compile-time only `require` of eieio doesn't make
> much sense.

You're right, thanks.

Re: [Emacs-diffs] master 3f06795: Migrate auth-source to cl-lib

[Ted Zlatanov]

Followup for Mark: you removed many auth-source.el comments that were
still pertinent after your great rewrite. Would you consider bringing
them back?

Thanks
Ted

Re: [Emacs-diffs] master 3f06795: Migrate auth-source to cl-lib

[Mark Oteiza]

Ted Zlatanov <tzz@lifelogs.com> writes:

> Followup for Mark: you removed many auth-source.el comments that were
> still pertinent after your great rewrite. Would you consider bringing
> them back?

Indeed a couple were lost!  I will restore them.

Re: [Emacs-diffs] master 3f06795: Migrate auth-source to cl-lib

[Stefan Monnier]

> @@ -712,7 +712,7 @@ must call it to obtain the actual value."
>                         (plist-get spec key)
>                         (slot-value backend key))
>                  (setq filtered-backends (delq backend filtered-backends))
> -                (return))
> +                (cl-return))
>              (invalid-slot-name nil))))

Hmm... This change looks right, but I believe there's a bug here:
with `cl`, `dolist` is advised to be CL's `dolist` which includes an
implicit (block nil ...) wrapper.  But with cl-lib, `dolist` is left alone
and you need to use `cl-dolist` to get that wrapper.

So I think you need to change the surrounding `dolist` to be `cl-dolist`
otherwise this `cl-return` will exit from the surrounding function
rather than from the inner loop.


        Stefan

Re: [Emacs-diffs] master 3f06795: Migrate auth-source to cl-lib

[Mark Oteiza]

On 12/11/16 at 05:57pm, Stefan Monnier wrote:
> > @@ -712,7 +712,7 @@ must call it to obtain the actual value."
> >                         (plist-get spec key)
> >                         (slot-value backend key))
> >                  (setq filtered-backends (delq backend filtered-backends))
> > -                (return))
> > +                (cl-return))
> >              (invalid-slot-name nil))))
> 
> Hmm... This change looks right, but I believe there's a bug here:
> with `cl`, `dolist` is advised to be CL's `dolist` which includes an
> implicit (block nil ...) wrapper.  But with cl-lib, `dolist` is left alone
> and you need to use `cl-dolist` to get that wrapper.
> 
> So I think you need to change the surrounding `dolist` to be `cl-dolist`
> otherwise this `cl-return` will exit from the surrounding function
> rather than from the inner loop.

Argh, I caught one of the dolist/return but missed this one.
Thanks, fixed.