[PATCH] bind n and p in eww bookmark and histories

[PATCH] bind n and p in eww bookmark and histories

[Mark Oteiza]

Hi Lars,

I'd like to add these bindings.  Not sure if there is a plan for n and p
to do something else in eww's bookmark or history, judging from the
comments nixed below.

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 7672bf0..1732682 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1736,6 +1736,8 @@ eww-bookmark-mode-map
     (define-key map [(control k)] 'eww-bookmark-kill)
     (define-key map [(control y)] 'eww-bookmark-yank)
     (define-key map "\r" 'eww-bookmark-browse)
+    (define-key map "n" 'next-line)
+    (define-key map "p" 'previous-line)
 
     (easy-menu-define nil map
       "Menu for `eww-bookmark-mode-map'."
@@ -1818,8 +1820,8 @@ eww-history-browse
 (defvar eww-history-mode-map
   (let ((map (make-sparse-keymap)))
     (define-key map "\r" 'eww-history-browse)
-;;    (define-key map "n" 'next-error-no-select)
-;;    (define-key map "p" 'previous-error-no-select)
+    (define-key map "n" 'next-line)
+    (define-key map "p" 'previous-line)
 
     (easy-menu-define nil map
       "Menu for `eww-history-mode-map'."

Re: [PATCH] bind n and p in eww bookmark and histories

[Lars Ingebrigtsen]

Mark Oteiza <mvoteiza@udel.edu> writes:

> I'd like to add these bindings.  Not sure if there is a plan for n and p
> to do something else in eww's bookmark or history, judging from the
> comments nixed below.
>
> diff --git a/lisp/net/eww.el b/lisp/net/eww.el
> index 7672bf0..1732682 100644
> --- a/lisp/net/eww.el
> +++ b/lisp/net/eww.el
> @@ -1736,6 +1736,8 @@ eww-bookmark-mode-map
>      (define-key map [(control k)] 'eww-bookmark-kill)
>      (define-key map [(control y)] 'eww-bookmark-yank)
>      (define-key map "\r" 'eww-bookmark-browse)
> +    (define-key map "n" 'next-line)
> +    (define-key map "p" 'previous-line)
>
>      (easy-menu-define nil map
>        "Menu for `eww-bookmark-mode-map'."
> @@ -1818,8 +1820,8 @@ eww-history-browse
>  (defvar eww-history-mode-map
>    (let ((map (make-sparse-keymap)))
>      (define-key map "\r" 'eww-history-browse)
> -;;    (define-key map "n" 'next-error-no-select)
> -;;    (define-key map "p" 'previous-error-no-select)
> +    (define-key map "n" 'next-line)
> +    (define-key map "p" 'previous-line)

I'm not sure taking keystrokes we may well want to use later for cursor
movements makes all that much sense.  People are perfectly capable to
move the point around without mode-specific bindings, I think.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: [PATCH] bind n and p in eww bookmark and histories

[Mark Oteiza]

On 10/11/16 at 07:12pm, Lars Ingebrigtsen wrote:
> Mark Oteiza <mvoteiza@udel.edu> writes:
> 
> > I'd like to add these bindings.  Not sure if there is a plan for n and p
> > to do something else in eww's bookmark or history, judging from the
> > comments nixed below.
> >
> > diff --git a/lisp/net/eww.el b/lisp/net/eww.el
> > index 7672bf0..1732682 100644
> > --- a/lisp/net/eww.el
> > +++ b/lisp/net/eww.el
> > @@ -1736,6 +1736,8 @@ eww-bookmark-mode-map
> >      (define-key map [(control k)] 'eww-bookmark-kill)
> >      (define-key map [(control y)] 'eww-bookmark-yank)
> >      (define-key map "\r" 'eww-bookmark-browse)
> > +    (define-key map "n" 'next-line)
> > +    (define-key map "p" 'previous-line)
> >
> >      (easy-menu-define nil map
> >        "Menu for `eww-bookmark-mode-map'."
> > @@ -1818,8 +1820,8 @@ eww-history-browse
> >  (defvar eww-history-mode-map
> >    (let ((map (make-sparse-keymap)))
> >      (define-key map "\r" 'eww-history-browse)
> > -;;    (define-key map "n" 'next-error-no-select)
> > -;;    (define-key map "p" 'previous-error-no-select)
> > +    (define-key map "n" 'next-line)
> > +    (define-key map "p" 'previous-line)
> 
> I'm not sure taking keystrokes we may well want to use later for cursor
> movements makes all that much sense.  People are perfectly capable to
> move the point around without mode-specific bindings, I think.  :-)

It is common for special-modes to have n and p bound to cursor
movements, and those maps have been untouched for a couple years now.