From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 24767@debbugs.gnu.org
Subject: bug#24767: jgraph comments not recognized any more
Date: Mon, 24 Oct 2016 19:34:51 +0000 [thread overview]
Message-ID: <20161024193451.GA4544@acm.fritz.box> (raw)
In-Reply-To: <jwva8dwyt5a.fsf@iro.umontreal.ca>
Hello, Stefan.
On Sat, Oct 22, 2016 at 05:24:01PM -0400, Stefan Monnier wrote:
> Package: Emacs
> Try the following:
> % emacs -Q -l .../elpa/packages/jgraph-mode/jgraph-mode.el ~/foo.jgr
> (* hello *)
> The string "(* hello *)" should be highlighted as a comment, and is
> indeed correctly highlighted this way in Emacs-25 (and Emacs-24), but
> not in "master".
> The particularity of jgraph-mode's handling of (*...*) is that ?(, ?),
> and ?* are given "symbol" syntax, so I guess that src/syntax.c was
> modified in a way which makes it skip the whole (* as being a symbol.
Suppose the jgraph buffer contains:
he(*llo*)
. Is this supposed to analyse as the symbol "he" followed by a comment,
or should it be the symbol "he(*llo*)"? Currently, even Emacs-25
doesn't recognise the "(*llo*)" as a comment. It seems to me more
likely that the comment should be recognised, but I don't know jgraph.
To blame for this is the section of code in scan_sexps_forward (in
Emacs-25) just after the label symstarted: where there is a subsidiary
loop on "(from < end)" which doesn't do any checking on the comment
flags.
Maybe the solution (in master) would be to add the checking of the
comment flags into this subsidiary loop.
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2016-10-24 19:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-22 21:24 bug#24767: jgraph comments not recognized any more Stefan Monnier
2016-10-23 6:17 ` Eli Zaretskii
2016-10-23 15:34 ` Alan Mackenzie
2016-10-24 19:34 ` Alan Mackenzie [this message]
2016-10-25 13:52 ` Stefan Monnier
2016-10-29 11:02 ` Alan Mackenzie
2016-10-29 15:12 ` Stefan Monnier
2016-10-30 17:37 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024193451.GA4544@acm.fritz.box \
--to=acm@muc.de \
--cc=24767@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.