From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#24579: [PATCH] borderless windows on OS X Date: Sat, 1 Oct 2016 22:26:13 +0100 Message-ID: <20161001212613.GA40646@breton.holly.idiocy.org> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1475357240 5489 195.159.176.226 (1 Oct 2016 21:27:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 1 Oct 2016 21:27:20 +0000 (UTC) User-Agent: Mutt/1.7.0 (2016-08-17) Cc: 24579@debbugs.gnu.org To: Jay McCarthy Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 01 23:27:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqRoP-0000eF-76 for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Oct 2016 23:27:13 +0200 Original-Received: from localhost ([::1]:57238 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqRoN-0001LR-TY for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Oct 2016 17:27:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqRoI-0001Kx-11 for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 17:27:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqRoE-0008TF-PH for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 17:27:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqRoD-0008T1-TD for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 17:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bqRoD-0005pR-Km for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2016 17:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Oct 2016 21:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24579 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24579-submit@debbugs.gnu.org id=B24579.147535718322360 (code B ref 24579); Sat, 01 Oct 2016 21:27:01 +0000 Original-Received: (at 24579) by debbugs.gnu.org; 1 Oct 2016 21:26:23 +0000 Original-Received: from localhost ([127.0.0.1]:41378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqRnb-0005oa-G2 for submit@debbugs.gnu.org; Sat, 01 Oct 2016 17:26:23 -0400 Original-Received: from mail-wm0-f54.google.com ([74.125.82.54]:36101) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqRnZ-0005oM-TC for 24579@debbugs.gnu.org; Sat, 01 Oct 2016 17:26:22 -0400 Original-Received: by mail-wm0-f54.google.com with SMTP id k125so85408099wma.1 for <24579@debbugs.gnu.org>; Sat, 01 Oct 2016 14:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Tj9Fajq1++d0owRZAdraOv1UhC0+uPJUDNz+BNsUlwo=; b=0etrCpVRnDN+u8iA7stqtRlpXBFJMp2Hxd+eDpIhj14F4LhzUCZUcB03XRUixe0AVY fFdJTuYV8Zpbnh0iwY81JzAFe/HBQMucJzUD2aRUKewerHgkSBOGzAqBKpsbjmLTGvH+ 5bb0aQMGSKldomwhBqha6kkKJ3C/fnizd/x3dnJS/EW2PUN9MID2C0b1GziFA2YdAwZ3 BAMSsp3IXgu8eMZDTzXorsObw2vyfGeDAg3/5sZy7IJIQd+JaLLOj8XVG8zVQOEiO/CB RGHyZofl22k4kLWiMcswH3PIcsSOP2Rop56poKcnT82QvLwuE7NmLRHVGSprRQC3UT01 bQnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=Tj9Fajq1++d0owRZAdraOv1UhC0+uPJUDNz+BNsUlwo=; b=AkWLGhmAqpKtUWaQQaO0b80d+G/rVPqf3/K+VNwQbLn5dbSx8gvTARNoJKg7ZSwmUW DLVPt3VIXVx7R2+JRI6Oo5eD5AYPjmekynaq2VnXili8kP3SlsXcj2/4oz1prwrSZSXT 9sQpyq/BOytb7YlGRAdxKwjUypm0vJkMT+2fzNbO2DL9vdpYyWlmOJiEj7gz6qVNBST9 G+ggoLNVvzeCjy5ORZbhVtGlYx6oeYFvV3D7kryL1hpvu/zKmlV/ru4zwmieVHKQ1Xev vDKP7Nn4Iay3RvZoP2LQ/NE3Sy38ZLiH1ETlV5cL/eNIFhFajzmV9BJRNTY3lTgwGR3h OaiA== X-Gm-Message-State: AA6/9RkexP5LXrdVa8mNVSzr3maonN9/eLGTRD1sUktEGkaKzGaVp9KhjrctVR91CkAHXA== X-Received: by 10.28.149.77 with SMTP id x74mr3653386wmd.95.1475357176051; Sat, 01 Oct 2016 14:26:16 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-148d-3f02-0cb7-1071.holly.idiocy.org. [2001:8b0:3f8:8129:148d:3f02:cb7:1071]) by smtp.gmail.com with ESMTPSA id a1sm5924585wjl.28.2016.10.01.14.26.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 01 Oct 2016 14:26:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123878 Archived-At: On Fri, Sep 30, 2016 at 09:31:09PM -0400, Jay McCarthy wrote: > There are two popular Emacs patches for OS X that make all its windows > have no title bar: > > https://github.com/nikhilunni/BorderlessEmacs > > https://github.com/gwydirsam/emacs-mac-borderless > > This patch integrates these by providing a variable > (ns-use-titled-windows) that allows this decision to be controlled at > runtime. The default is to use titles, like normal. I’d prefer a variable name more like ‘ns-use-titlebar’, as ‘titled-windows’ doesn’t mean very much to me. > -- Some comments on the patch > > This is my first Emacs patch. I hope it's okay. > > The only difference between EmacsFSWindow and EmacsWindow is > explicitly telling OS X that the window can be the subject of focus, > which is required for borderless windows. (EmacsFSWindow has nothing > to do with being fullscreen.) I’d no idea about this, do we even need both types? > I included a note in the Changelog, because it looks like all > variables like this get put in, but it could be removed from my > perspective... I have no need to satisfy my pride with my name in the > log. However, I didn't add anything to NEWS, because it seems to not > always mention things like this. The changelog is automatically updated from the git repository log, as I understand it. We’ll commit it using your name so you’ll be credited anyway. :) Also, I don’t think this patch will be included before Emacs 26.1 as it’s a new feature, not a bug fix, so the entry in cus-start.el may need to read 26.1. This one’s a real nit‐pick: I don’t like the version number being on the next line in the variable doctype. I don’t see any reason why it can’t be moved up on to the previous line next to the greater‐than sign. And also change ‘windows’ to ‘frames’ and ‘title’ to ‘titlebar’. I can’t see anything wrong other than my little moans above, and it certainly looks like it does what it’s supposed to do. Thanks for doing this. -- Alan Third