From: Alan Third <alan@idiocy.org>
To: Jay McCarthy <jay.mccarthy@gmail.com>
Cc: 24579@debbugs.gnu.org
Subject: bug#24579: [PATCH] borderless windows on OS X
Date: Sat, 1 Oct 2016 22:26:13 +0100 [thread overview]
Message-ID: <20161001212613.GA40646@breton.holly.idiocy.org> (raw)
In-Reply-To: <CAJYbDamXwyEXxZUPrn9=pXAzQhjq-sEu0pAfedxuMuKSx+MUBQ@mail.gmail.com>
On Fri, Sep 30, 2016 at 09:31:09PM -0400, Jay McCarthy wrote:
> There are two popular Emacs patches for OS X that make all its windows
> have no title bar:
>
> https://github.com/nikhilunni/BorderlessEmacs
>
> https://github.com/gwydirsam/emacs-mac-borderless
>
> This patch integrates these by providing a variable
> (ns-use-titled-windows) that allows this decision to be controlled at
> runtime. The default is to use titles, like normal.
I’d prefer a variable name more like ‘ns-use-titlebar’, as
‘titled-windows’ doesn’t mean very much to me.
> -- Some comments on the patch
>
> This is my first Emacs patch. I hope it's okay.
>
> The only difference between EmacsFSWindow and EmacsWindow is
> explicitly telling OS X that the window can be the subject of focus,
> which is required for borderless windows. (EmacsFSWindow has nothing
> to do with being fullscreen.)
I’d no idea about this, do we even need both types?
> I included a note in the Changelog, because it looks like all
> variables like this get put in, but it could be removed from my
> perspective... I have no need to satisfy my pride with my name in the
> log. However, I didn't add anything to NEWS, because it seems to not
> always mention things like this.
The changelog is automatically updated from the git repository log, as
I understand it. We’ll commit it using your name so you’ll be credited
anyway. :)
Also, I don’t think this patch will be included before Emacs 26.1 as
it’s a new feature, not a bug fix, so the entry in cus-start.el may
need to read 26.1.
This one’s a real nit‐pick: I don’t like the version number being on
the next line in the variable doctype. I don’t see any reason why it
can’t be moved up on to the previous line next to the greater‐than
sign. And also change ‘windows’ to ‘frames’ and ‘title’ to ‘titlebar’.
I can’t see anything wrong other than my little moans above, and it
certainly looks like it does what it’s supposed to do. Thanks for
doing this.
--
Alan Third
next prev parent reply other threads:[~2016-10-01 21:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-01 1:31 bug#24579: [PATCH] borderless windows on OS X Jay McCarthy
2016-10-01 8:44 ` martin rudalics
2016-10-01 11:53 ` Jay McCarthy
2016-10-01 13:41 ` martin rudalics
2016-10-01 20:18 ` Jay McCarthy
2016-10-02 8:29 ` martin rudalics
2016-10-13 17:56 ` Jay McCarthy
2016-10-13 18:36 ` martin rudalics
2016-10-13 22:27 ` Jay McCarthy
2016-10-01 21:26 ` Alan Third [this message]
2016-10-01 22:18 ` Jay McCarthy
2016-10-01 23:04 ` Alan Third
2016-10-02 0:49 ` Clément Pit--Claudel
2016-10-02 8:30 ` martin rudalics
2016-10-02 15:07 ` Alan Third
2016-10-02 16:39 ` martin rudalics
2016-10-02 16:49 ` Alan Third
2016-10-02 18:10 ` martin rudalics
2016-10-02 18:31 ` Clément Pit--Claudel
2016-10-02 15:18 ` Clément Pit--Claudel
2016-10-02 16:39 ` martin rudalics
2016-10-02 16:50 ` Clément Pit--Claudel
2016-10-02 18:09 ` martin rudalics
2017-04-21 19:49 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161001212613.GA40646@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=24579@debbugs.gnu.org \
--cc=jay.mccarthy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.