all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mark Oteiza <mvoteiza@udel.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: jwiegley@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: [PATCH] lexical-binding mega-patch (was: Re: [Emacs-diffs] master 05dc679: Turn on lexical-binding in json.el)
Date: Wed, 28 Sep 2016 13:17:20 -0400	[thread overview]
Message-ID: <20160928171720.GA13522@holos.localdomain> (raw)
In-Reply-To: <83mvkgcyh1.fsf@gnu.org>

On 13/08/16 at 09:31pm, Eli Zaretskii wrote:
> > Date: Sat, 13 Aug 2016 14:18:32 -0400
> > From: Mark Oteiza <mvoteiza@udel.edu>
> > Cc: emacs-devel@gnu.org, John Wiegley <jwiegley@gmail.com>,
> > 	Eli Zaretskii <eliz@gnu.org>
> > 
> > On 10/08/16 at 10:36pm, Stefan Monnier wrote:
> > > > Seems like a lot of low hanging fruit to pick and I should post
> > > > a patch, WDYT?
> > > 
> > > Go for it.
> > 
> > Done.  Flipped the switch and fixed small warnings on files in
> > lisp/*.el, but didn't bother with fixing other kinds of warnings or
> > altering libs actually using dynamic binding or didn't already have
> > a compile-time dependency on cl{,-lib} for {,cl-}pushnew.  Nothing
> > appears to be broken, but AFAIK I don't make regular use of many of
> > these libraries.
> 
> IMO, we should have tests for each one of them before we do this.
> 
> Thanks.

Did the above in cbb2e84518 for files that already had tests written.
Tests passed.



  parent reply	other threads:[~2016-09-28 17:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160810044910.10174.12870@vcs.savannah.gnu.org>
     [not found] ` <20160810044911.2B1C52201C2@vcs.savannah.gnu.org>
2016-08-10 15:45   ` [Emacs-diffs] master 05dc679: Turn on lexical-binding in json.el Stefan Monnier
2016-08-11  1:30     ` Mark Oteiza
2016-08-11  2:36       ` Stefan Monnier
2016-08-12 19:07         ` Stephen Berman
2016-08-12 19:43           ` Stefan Monnier
2016-08-13 18:18         ` [PATCH] lexical-binding mega-patch (was: Re: [Emacs-diffs] master 05dc679: Turn on lexical-binding in json.el) Mark Oteiza
2016-08-13 18:31           ` Eli Zaretskii
2016-08-14  6:32             ` [PATCH] lexical-binding mega-patch John Wiegley
2016-08-14 18:21               ` Mark Oteiza
2016-09-28 17:17             ` Mark Oteiza [this message]
2016-09-29 15:21               ` [PATCH] lexical-binding mega-patch (was: Re: [Emacs-diffs] master 05dc679: Turn on lexical-binding in json.el) Eli Zaretskii
2016-08-14  2:18           ` Chad Brown
2016-08-11  5:30       ` [Emacs-diffs] master 05dc679: Turn on lexical-binding in json.el Richard Stallman
2016-08-11 17:34     ` John Wiegley
2016-08-11 20:35       ` Stefan Monnier
2016-08-12  6:37         ` Eli Zaretskii
2016-08-12 12:41           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160928171720.GA13522@holos.localdomain \
    --to=mvoteiza@udel.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jwiegley@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.