From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 4ffdcfc: Nudge WoMan toward lexical-binding Date: Tue, 27 Sep 2016 13:43:20 -0400 Message-ID: <20160927174320.GA13830@holos.localdomain> References: <20160810042245.19283.98654@vcs.savannah.gnu.org> <20160810042245.914B52201C2@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1474998253 26260 195.159.176.226 (27 Sep 2016 17:44:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 27 Sep 2016 17:44:13 +0000 (UTC) User-Agent: Mutt/1.7+23 (87911ba95dae) (2016-08-17) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 27 19:44:10 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bowQC-0005Mr-5j for ged-emacs-devel@m.gmane.org; Tue, 27 Sep 2016 19:44:00 +0200 Original-Received: from localhost ([::1]:52622 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bowQA-0000PP-HB for ged-emacs-devel@m.gmane.org; Tue, 27 Sep 2016 13:43:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bowPf-0000LI-OG for emacs-devel@gnu.org; Tue, 27 Sep 2016 13:43:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bowPb-00056U-J0 for emacs-devel@gnu.org; Tue, 27 Sep 2016 13:43:26 -0400 Original-Received: from mail-qk0-x229.google.com ([2607:f8b0:400d:c09::229]:33488) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bowPb-00056F-ET for emacs-devel@gnu.org; Tue, 27 Sep 2016 13:43:23 -0400 Original-Received: by mail-qk0-x229.google.com with SMTP id g67so24014667qkd.0 for ; Tue, 27 Sep 2016 10:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=g+AtU9s1c7Asy2wpE5H/UWAzC2nCJhn47g0zW7A0dlk=; b=HI87UiNNitk7kUIKbmqAj95DQ9NCGxt4E00f3vEQrth7UksTR6Y+KTHZZ0VzxrEVVQ gMtZUFY36GRi09OKPUKdm6FvY8VwWeuXJcikP+j50IJJ4mGySv3vMGVNNQnrEEg+lPaF LzpiNeJBJsWTNnq99hR+ICPQt2qKmugVqbIpkklhus/vR7mLac42n9F+7y4Vj3JgduEU 14/VxFGyqMVRG7Y265j9wZZKsWshHiz0sUvAmyLLkQgKfrUhdnxQofrDKEnVgA1+T3ci gKiCIteKCJd8UGP8VICQHrOuuKTmk+scmGKODYu5kaQuLmLlN92+Q+yd+EmhBY1WaWOe DOAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=g+AtU9s1c7Asy2wpE5H/UWAzC2nCJhn47g0zW7A0dlk=; b=mYjGLHxj3ijdEUw6BVttu0KzwER14W3hZUoJBArmIGXz27pw312czZ9mr9wP3/Lzfc ij8NQqUey37vpC05bgQuhoUIRL6XMxqODqsW3ExnmUjfV6w1SA9oiYoAk+k5yKS+Teo9 epVQkhJV06idFPtZ3RYaKEzaa3MnZugvtWIm9X80bFXsXS/I9tbsTIRN9Pk3z9WJyNZj 3IdGreGT8yT/1H2sMhxDjCzqDra732BRKKAFr+FTGl0iUMuaHeymqQSx3WUMyoAxmBYI H4n3t81hxyL2EuILNTsAo+I3BYlDfoHUG2rkEiKT+o3ojKl11r8ySgOW4iUUg39g+FEG Sd0g== X-Gm-Message-State: AA6/9Rkv8DSxJ+3sdSbJ4bVF2oI6IIonthN/zFJiq9cKy6AqcVJKGsGrJX5uOf/bPAowZfam X-Received: by 10.55.99.17 with SMTP id x17mr30256831qkb.261.1474998202401; Tue, 27 Sep 2016 10:43:22 -0700 (PDT) Original-Received: from holos.localdomain ([69.250.222.218]) by smtp.gmail.com with ESMTPSA id n77sm1754963qkn.38.2016.09.27.10.43.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Sep 2016 10:43:21 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 19002658C5; Tue, 27 Sep 2016 13:43:20 -0400 (EDT) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207839 Archived-At: On 25/08/16 at 12:48am, Stefan Monnier wrote: > > - (add-to-list 'manpath > > - (if (match-beginning 1) > > - (match-string 1) > > - (cons (match-string 2) > > - (match-string 3))))) > > + (cl-pushnew (if (match-beginning 1) > > + (match-string 1) > > + (cons (match-string 2) > > + (match-string 3))) > > + manpath)) > > cl-pushnew uses `eql` (contrary to add-to-list which uses `equal`) for > equality testing. So when applied to value that have just been > constructed by `cons` and `match-string`, it will do exactly the same as > `push` would. > > IOW I think you need to add > > :test #'equal > > as arg to many of those cl-pushnew you introduced. Thanks, fixed in 329e0274. > Note that in my experience there are also some `add-to-list`s which > don't actually care about equality testing at all and can just be > replaced by a simple `push`. Some of these probably should have been push, in this particular case I suppose it makes little difference. Thanks again.