From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#24449: Emacs 25.1 RC2: Byte compiler reports error in wrong place. Date: Sat, 17 Sep 2016 12:58:36 +0000 Message-ID: <20160917125836.GB3410@acm.fritz.box> References: <20160916113124.GB3630@acm.fritz.box> <83wpic3rpb.fsf@gnu.org> <20160916133352.GC3630@acm.fritz.box> <83twdf51al.fsf@gnu.org> <20160916183451.GE3630@acm.fritz.box> <83poo34qg5.fsf@gnu.org> <20160917082952.GA3410@acm.fritz.box> <83intu50om.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1474117226 25105 195.159.176.226 (17 Sep 2016 13:00:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Sep 2016 13:00:26 +0000 (UTC) User-Agent: Mutt/1.5.24 (2015-08-30) Cc: 24449-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 17 15:00:22 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1blFE9-0005SP-Jw for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Sep 2016 15:00:17 +0200 Original-Received: from localhost ([::1]:46135 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blFE7-0002H0-OC for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Sep 2016 09:00:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blFE0-0002C7-D2 for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2016 09:00:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1blFDv-0003E4-Fu for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2016 09:00:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36061) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blFDv-0003Dn-Cf for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2016 09:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1blFDv-0001r3-4Y for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2016 09:00:03 -0400 Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Sep 2016 13:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 24449 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 24449@debbugs.gnu.org, acm@muc.de, acm@muc.de Original-Received: via spool by 24449-done@debbugs.gnu.org id=D24449.14741171457024 (code D ref 24449); Sat, 17 Sep 2016 13:00:02 +0000 Original-Received: (at 24449-done) by debbugs.gnu.org; 17 Sep 2016 12:59:05 +0000 Original-Received: from localhost ([127.0.0.1]:33773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1blFCz-0001pE-4D for submit@debbugs.gnu.org; Sat, 17 Sep 2016 08:59:05 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:16648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1blFCw-0001oo-9O for 24449-done@debbugs.gnu.org; Sat, 17 Sep 2016 08:59:03 -0400 Original-Received: (qmail 10759 invoked by uid 3782); 17 Sep 2016 12:59:00 -0000 Original-Received: from acm.muc.de (p4FC46536.dip0.t-ipconnect.de [79.196.101.54]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 17 Sep 2016 14:58:58 +0200 Original-Received: (qmail 3736 invoked by uid 1000); 17 Sep 2016 12:58:36 -0000 Content-Disposition: inline In-Reply-To: <83intu50om.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123403 Archived-At: Hello, Eli. On Sat, Sep 17, 2016 at 12:35:05PM +0300, Eli Zaretskii wrote: > > Date: Sat, 17 Sep 2016 08:29:52 +0000 > > Cc: 24449@debbugs.gnu.org > > From: Alan Mackenzie > > 5. The change I made yesterday appears not to have made anything any > > worse. > Thanks, I guess that means you should push it. Done. I took the liberty of amending the comment before `byte-compile-set-symbol-position'. > > What I would suggest should get done: we should make the column numbers > > 0-based > This should be a separate change, and before doing it, we should make > sure to fix code that assumes the columns to be 1-based (e.g, what > does "C-x `" do?). Ah. OK. > > suitable places to call `byte-compile-set-symbol-position' for > > the error messages we see should be identified, the calls inserted, and > > another bootstrap build done to see how much this helps. > Sounds a good idea, thanks. Done this too, in one place, which causes the "obsolete function" messages to get the correct position. Messages generated by `macroexp--warn-and-return' continue to have wrong positions. I'm not sure it's possible to fix this, and my intellect isn't up to working out how it works, at least not today. The messages about unknown functions, or not known to be defined at runtime functions continue to give EOF as their position. This was the use case for the parameter `allow-previous' in `byte-compile-set-symbol-position', but it didn't work before, and it continues not to work just as well now. It would be possible to fix this by not deleting elements from `read-symbol-positions-list', but this would slow down compilation (even if only a little), and generally seems not to be worth the trouble. -- Alan Mackenzie (Nuremberg, Germany).