From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#24449: Emacs 25.1 RC2: Byte compiler reports error in wrong place. Date: Fri, 16 Sep 2016 13:33:52 +0000 Message-ID: <20160916133352.GC3630@acm.fritz.box> References: <20160916113124.GB3630@acm.fritz.box> <83wpic3rpb.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1474032967 26799 195.159.176.226 (16 Sep 2016 13:36:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 16 Sep 2016 13:36:07 +0000 (UTC) User-Agent: Mutt/1.5.24 (2015-08-30) Cc: 24449@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 16 15:36:00 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bktJ6-0005pd-2J for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Sep 2016 15:35:56 +0200 Original-Received: from localhost ([::1]:40591 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bktJ4-0000Fm-Am for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Sep 2016 09:35:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bktIJ-0008Bs-PW for bug-gnu-emacs@gnu.org; Fri, 16 Sep 2016 09:35:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bktIE-0001U6-OO for bug-gnu-emacs@gnu.org; Fri, 16 Sep 2016 09:35:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bktIE-0001T8-M7 for bug-gnu-emacs@gnu.org; Fri, 16 Sep 2016 09:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bktIE-0004Oj-Aw for bug-gnu-emacs@gnu.org; Fri, 16 Sep 2016 09:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Sep 2016 13:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24449 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24449-submit@debbugs.gnu.org id=B24449.147403287016859 (code B ref 24449); Fri, 16 Sep 2016 13:35:02 +0000 Original-Received: (at 24449) by debbugs.gnu.org; 16 Sep 2016 13:34:30 +0000 Original-Received: from localhost ([127.0.0.1]:32867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bktHd-0004Nn-DH for submit@debbugs.gnu.org; Fri, 16 Sep 2016 09:34:29 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:44792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bktHX-0004NZ-BC for 24449@debbugs.gnu.org; Fri, 16 Sep 2016 09:34:23 -0400 Original-Received: (qmail 83323 invoked by uid 3782); 16 Sep 2016 13:34:17 -0000 Original-Received: from acm.muc.de (p548C6AC0.dip0.t-ipconnect.de [84.140.106.192]) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 16 Sep 2016 15:34:15 +0200 Original-Received: (qmail 13165 invoked by uid 1000); 16 Sep 2016 13:33:52 -0000 Content-Disposition: inline In-Reply-To: <83wpic3rpb.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123383 Archived-At: Hello, Eli. On Fri, Sep 16, 2016 at 04:22:08PM +0300, Eli Zaretskii wrote: > > Date: Fri, 16 Sep 2016 11:31:25 +0000 > > From: Alan Mackenzie > > > > $ emacs -Q -batch -f batch-byte-compile cc-engine.el > > > > . This outputs the following warning: > > > > In c-forward-decl-or-cast-1: > > cc-engine.el:8105:22:Warning: reference to free variable `eq' > > > > . The use of `eq' on L8105 is entirely correct. The error is at L8636, > > where the following appears: > > > > (and eq context nil > > (match-beginning 1)) > > > > . Clearly parentheses around the `eq' form are missing. > > > > The compiler should have output its warning for L8636, not L8105. > Did you look at how the byte compiler determines the line number it > will include in the warning/error message? I'm looking at it now, with a view to making it work. > If you didn't, you should, because after you do, you will never again > wonder why an incorrect line number is reported. In fact, now that I > did look there, I'm surprised it reports a correct line number at all, > let alone as often as it does. It's sheer luck. This is not a Good Thing. Even its own comment describes itself as a "gross hack". Surely we can do better? -- Alan Mackenzie (Nuremberg, Germany).