From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: CC-mode highlight change between 24.5 and 25 Date: Sun, 11 Sep 2016 21:22:55 +0000 Message-ID: <20160911212255.GA12628@acm.fritz.box> References: <878tvaeco8.fsf@oremacs.com> <20160902132704.GC4439@acm.fritz.box> <87poomcrm3.fsf@oremacs.com> <20160904153800.GB3554@acm.fritz.box> <87d1kid7cj.fsf@oremacs.com> <20160905152034.GA4899@acm.fritz.box> <874m5tp2rw.fsf@oremacs.com> <20160906170217.GA6388@acm.fritz.box> <20160907141013.GC2145@acm.fritz.box> <87r38tcrxl.fsf@oremacs.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1473629030 25930 195.159.176.226 (11 Sep 2016 21:23:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 11 Sep 2016 21:23:50 +0000 (UTC) User-Agent: Mutt/1.5.24 (2015-08-30) Cc: emacs-devel@gnu.org To: Oleh Krehel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 11 23:23:46 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjCE2-0005nz-Il for ged-emacs-devel@m.gmane.org; Sun, 11 Sep 2016 23:23:42 +0200 Original-Received: from localhost ([::1]:39131 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjCE0-0004il-0N for ged-emacs-devel@m.gmane.org; Sun, 11 Sep 2016 17:23:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjCDn-0004e4-Nt for emacs-devel@gnu.org; Sun, 11 Sep 2016 17:23:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjCDk-0005Tj-HI for emacs-devel@gnu.org; Sun, 11 Sep 2016 17:23:27 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:40875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjCDk-0005TI-7S for emacs-devel@gnu.org; Sun, 11 Sep 2016 17:23:24 -0400 Original-Received: (qmail 36175 invoked by uid 3782); 11 Sep 2016 21:23:21 -0000 Original-Received: from acm.muc.de (p548C6692.dip0.t-ipconnect.de [84.140.102.146]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 11 Sep 2016 23:23:20 +0200 Original-Received: (qmail 12633 invoked by uid 1000); 11 Sep 2016 21:22:55 -0000 Content-Disposition: inline In-Reply-To: <87r38tcrxl.fsf@oremacs.com> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-Received-From: 193.149.48.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207369 Archived-At: Hello, Oleh. On Fri, Sep 09, 2016 at 12:01:58PM +0200, Oleh Krehel wrote: > Hi Alan, > > OK, time for a fresh patch. We're getting there, slowly. > > > > This patch should fix the problems with cctest.cc, as described in my > > last post. It also fixes a problem in the "top-level" counting where > > the comma in "class foo : bar, baz { ...." caused the code to think that > > the "...." weren't at top level. > > > > Again, please try this out on your real C++ code, and let me know how > > well it fares. > Thanks for the update. Everything looks good. All functions are > highlighted as functions, and non-functions aren't. I'll keep an eye out > for outliers, but it seems very solid now. I've now committed that patch, both to CC Mode at SourceForge and to the master branch at savannah. Let's hope it doesn't need too much adjustment in the future. > Oleh -- Alan Mackenzie (Nuremberg, Germany).