From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= Newsgroups: gmane.emacs.devel Subject: [PATCH] url: Wrap cookie headers in url-http--encode-string. Date: Wed, 7 Sep 2016 17:30:14 +0200 Message-ID: <20160907153014.15752-1-toke@toke.dk> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1473262254 30282 195.159.176.226 (7 Sep 2016 15:30:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 7 Sep 2016 15:30:54 +0000 (UTC) Cc: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 07 17:30:50 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bheoK-0007PF-UF for ged-emacs-devel@m.gmane.org; Wed, 07 Sep 2016 17:30:49 +0200 Original-Received: from localhost ([::1]:41574 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bheoL-0008MY-Ua for ged-emacs-devel@m.gmane.org; Wed, 07 Sep 2016 11:30:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bheoD-0008Lb-0C for emacs-devel@gnu.org; Wed, 07 Sep 2016 11:30:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bheo7-0005Uz-5E for emacs-devel@gnu.org; Wed, 07 Sep 2016 11:30:39 -0400 Original-Received: from mail2.tohojo.dk ([77.235.48.147]:41282) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bheo6-0005TL-Od for emacs-devel@gnu.org; Wed, 07 Sep 2016 11:30:35 -0400 X-Virus-Scanned: amavisd-new at mail2.tohojo.dk DKIM-Filter: OpenDKIM Filter v2.10.3 mail2.tohojo.dk A4A4540D5E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=201310; t=1473262225; bh=GNHWAaI9XPRRr/b52WiziGyrm6r4HahcOU4AAPZklJc=; h=From:To:Cc:Subject:Date:From; b=jXXvYunLuAj12XpB3h2hegCDgg2+ZDMcBjM2jYTdG9YoDRtxB6OiXTQZSE2oi0qOj GO8YxU+tLgkc1Krs27654oqsZgduFyQFAQ7eWwB2MaROlVB8FHm614D02xSDcXG86f CuZF8b4LoB22s0WrW7TUUK/Dz6r3PSHwUqV/WjG0= Original-Received: by alrua-kau.kau.toke.dk (Postfix, from userid 1000) id AB8CBC4027D; Wed, 7 Sep 2016 17:30:25 +0200 (CEST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.235.48.147 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207245 Archived-At: In some cases the output of url-cookie-generate-header can be multibyte, which will trip the length check that was added at the end of url-http-create-request. This seems to happen only when there's a request body which contains UTF-8-encoded non-ASCII characters. Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen --- lisp/url/url-http.el | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el index 927d0bb..81bb9b4 100644 --- a/lisp/url/url-http.el +++ b/lisp/url/url-http.el @@ -366,9 +366,10 @@ The string is based on `url-privacy-level' and `url-= user-agent'." auth ;; Cookies (when (url-use-cookies url-http-target-url) - (url-cookie-generate-header-lines - host real-fname - (equal "https" (url-type url-http-target-url)))) + (url-http--encode-string + (url-cookie-generate-header-lines + host real-fname + (equal "https" (url-type url-http-target-url))))) ;; If-modified-since (if (and (not no-cache) (member url-http-method '("GET" nil))) --=20 2.9.3