From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix macOS 12 deprecation notices Date: Wed, 24 Aug 2016 19:21:19 +0100 Message-ID: <20160824182119.GA36494@breton.holly.idiocy.org> References: <315BE3C4-D984-470E-A4B4-20C8148FBA5A@play-bow.org> <20160818190422.GA23177@breton.holly.idiocy.org> <87eg5ivc8k.fsf@Niukka.kon.iki.fi> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1472064589 11428 195.159.176.226 (24 Aug 2016 18:49:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 24 Aug 2016 18:49:49 +0000 (UTC) User-Agent: Mutt/1.6.0 (2016-04-01) Cc: emacs-devel@gnu.org To: Kalle Olavi Niemitalo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 24 20:49:46 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bcdF9-0002Sd-UM for ged-emacs-devel@m.gmane.org; Wed, 24 Aug 2016 20:49:44 +0200 Original-Received: from localhost ([::1]:52823 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bcdF7-0005Ww-7o for ged-emacs-devel@m.gmane.org; Wed, 24 Aug 2016 14:49:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bccni-0006hm-Uo for emacs-devel@gnu.org; Wed, 24 Aug 2016 14:21:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bccnh-00008y-Tw for emacs-devel@gnu.org; Wed, 24 Aug 2016 14:21:22 -0400 Original-Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:34896) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bccnh-00008s-Ml for emacs-devel@gnu.org; Wed, 24 Aug 2016 14:21:21 -0400 Original-Received: by mail-wm0-x243.google.com with SMTP id i5so3721048wmg.2 for ; Wed, 24 Aug 2016 11:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=jvRcgIxAp8mqyQ3tfn67uYTkOAIbZD/LTRd3ImZ1epc=; b=sjeZD+CMRZHnd3O1Q8DdSWM/KVUiTs3/b4P7CBIcBynbqAtxB5m+GwGQZPzfwnKgLH 4j8J6rM59x4o7H8aQEwGtlUszoYi/YosDb6vpaHqxaKCT4MgwexRkZxx56GKWq2Z6Nu1 wFHkLqUwxocq2tsuoTwuKqvq4c7BFq5IT4xHexZxyzJ/HGFcpsTz67vkxwVDbWYTN5rl 74w7l9xyCXjRwMJNh9kzz++TrltZ4o7hVdPMQw8VZblx/oQzM9wHYOEK48V7M5rNgdSr L7hpGF1Su7JUiwUQxasXYQOgErk2/qC3T4ZOhCbw9Dn8v+gLKFZcAVrUpNbdTXfJq5gj b3iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=jvRcgIxAp8mqyQ3tfn67uYTkOAIbZD/LTRd3ImZ1epc=; b=PDdHJtKQVasdS879P7X3SAHChmzPvKuWDMLxhO7LbUjMFfmZrJmqizBdYaWMm8ESen H9alb18b6vkoPZOO2QrHrIw9zdPnjlCUewIWsZRq/p0qOe+23Y0ZSzZEFFEKZDRyKFyr mfR5tJ7jody51uqlnKHFr6mYfLCFd1zk+qVyx1DkGT1I9UkiPlCoOc04stl2//mrGZzs +l+EMLh0B+CS+wOAHp6CCInuqOicG2pq6iUacsIhiP6N3/9xxYtHuJhuAkrIx7Z4ikWd ygv3/5DPuAUTeKacZL6PTHKqQ2gWAL3qiDbcjg+0HPKMLfhvfIHIFFhPh92tTpimBFEv YsJQ== X-Gm-Message-State: AE9vXwP/tS5AljMvHanWr87xUE8KiPfNk/G8IW1qhifrjE5dN/TJMCGNV0Bb9/iXfJZHsw== X-Received: by 10.28.55.21 with SMTP id e21mr4175010wma.80.1472062880726; Wed, 24 Aug 2016 11:21:20 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-0537-d9a7-0071-f159.holly.idiocy.org. [2001:8b0:3f8:8129:537:d9a7:71:f159]) by smtp.gmail.com with ESMTPSA id hy3sm11266368wjb.8.2016.08.24.11.21.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Aug 2016 11:21:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87eg5ivc8k.fsf@Niukka.kon.iki.fi> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206783 Archived-At: On Sun, Aug 21, 2016 at 09:59:23AM +0300, Kalle Olavi Niemitalo wrote: > Alan Third writes: > > > * src/nsterm.h: Add #defines to allow older versions of macOS to use the > > new constant names. > > * src/nsmenu.m: Replace old constant names with new. > > * src/nsterm.m: Replace old constant names with new. > > * src/nsfns.m: Replace old constant names with new. > > Your patch also removes two setMenuChangedMessagesEnabled calls > from src/nsmenu.m. That seems unrelated to constant names. Well spotted, I forgot about them. I’ve amended the commit message, and will push to master now. -- Alan Third