From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lexical-binding mega-patch Date: Sun, 14 Aug 2016 14:21:57 -0400 Message-ID: <20160814182157.GA24431@holos.localdomain> References: <20160810044910.10174.12870@vcs.savannah.gnu.org> <20160810044911.2B1C52201C2@vcs.savannah.gnu.org> <20160811013050.GA4775@holos.localdomain> <20160813181832.GA15753@holos.localdomain> <83mvkgcyh1.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1471198942 694 195.159.176.226 (14 Aug 2016 18:22:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 14 Aug 2016 18:22:22 +0000 (UTC) User-Agent: Mutt/1.6.2+18 (69bbe4da959f) (2016-07-01) To: Eli Zaretskii , monnier@iro.umontreal.ca, emacs-devel@gnu.org, John Wiegley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 14 20:22:17 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZ037-0008MX-L7 for ged-emacs-devel@m.gmane.org; Sun, 14 Aug 2016 20:22:17 +0200 Original-Received: from localhost ([::1]:33405 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZ034-0003YG-IS for ged-emacs-devel@m.gmane.org; Sun, 14 Aug 2016 14:22:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZ02x-0003Xy-9f for emacs-devel@gnu.org; Sun, 14 Aug 2016 14:22:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZ02r-0007AK-Bf for emacs-devel@gnu.org; Sun, 14 Aug 2016 14:22:07 -0400 Original-Received: from mail-yb0-x230.google.com ([2607:f8b0:4002:c09::230]:35531) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZ02r-0007A7-7b for emacs-devel@gnu.org; Sun, 14 Aug 2016 14:22:01 -0400 Original-Received: by mail-yb0-x230.google.com with SMTP id z96so9611466ybh.2 for ; Sun, 14 Aug 2016 11:21:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JGM2B9Qlu5I9+ViglyBcb9BwzdWg6V1LesvVRJkcA0o=; b=QbPAuCPfJJYmLsv8vCNe/e0S1uKoQzENJ5bSLJilPJeok2ideTTah1XPtlx+5Kv1oY +t4udM8qLjyYShPU0DF/dW5TgHe74eTTeEiFordb0QIclWmlgaN2KNa/nOOxjlSgY49E FnaWB2V284z8Hzf1LGZsep8OWsTLngkaHMSxesyrK04Of83W11kjmVH0/Rn4OOwH6kiu Id6BUB2Ezf1LB/IAITrNq5nOWVLFendqPz2Oa9MRGlOGIJlC7rPZOE+ZZNd3chFu4bWH xuV4rMqztdoD6QrN1acmHTzbUnsTr8TO+zDOxCnLhEevkvT2invLBmRludgtP5vtnJUj aktA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JGM2B9Qlu5I9+ViglyBcb9BwzdWg6V1LesvVRJkcA0o=; b=RwZJhzmoH+Q8vbaYvT/PgO7GDziBKKumtfduZuVlRlyjTLrSQoFshU/xhgedj0R9Dj LOLXBAZVS3uUsklwoXvQiE3AF3hQPVduZwlcoXuOWpe4Vnv9ig0Hf7ApY1yaEDD//Ee9 uqhMN7fO0Os26NjpT6n5ZFypKrc6nj4P7aX2oMvqQ3hkdL+wYIQnQgX9WxfAjt0Yolww 16Q0nj6Qpp0a4BVZOgwloicBFonn+ukNpdZKYeGrh1N8wBBZt7mNomQwXbte/QEJR0tW BvM9aaQkalqJN+q4sv/1RMQJMyoNMYAiekw3sbeQU2yTN106U9IuvpYuLICwUyE++SbQ KTFA== X-Gm-Message-State: AEkoousnUv4cFyYMYTN7Hg0ICW3Nt7v9iNxeibfUV2D3spS2jd13whQ2do+rIEezZFEPf5FK X-Received: by 10.37.65.10 with SMTP id o10mr17310838yba.167.1471198919378; Sun, 14 Aug 2016 11:21:59 -0700 (PDT) Original-Received: from holos.localdomain (pool-72-78-210-63.phlapa.fios.verizon.net. [72.78.210.63]) by smtp.gmail.com with ESMTPSA id l1sm8599416ywc.41.2016.08.14.11.21.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Aug 2016 11:21:58 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 7CCC16885C; Sun, 14 Aug 2016 14:21:57 -0400 (EDT) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4002:c09::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206600 Archived-At: On 13/08/16 at 11:32pm, John Wiegley wrote: > >>>>> Eli Zaretskii writes: > > >> Done. Flipped the switch and fixed small warnings on files in lisp/*.el, > >> but didn't bother with fixing other kinds of warnings or altering libs > >> actually using dynamic binding or didn't already have a compile-time > >> dependency on cl{,-lib} for {,cl-}pushnew. Nothing appears to be broken, > >> but AFAIK I don't make regular use of many of these libraries. > > > IMO, we should have tests for each one of them before we do this. > > Yes, I would love to see this too. And this would be a great reason to write > them. Having this enabled for 26 would be a good thing, I think. or just encourage writing tests when bugs are discovered.