From: Alan Third <alan@idiocy.org>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] fileio.c: introduce make_temp_name_buf
Date: Sun, 24 Jul 2016 21:01:02 +0100 [thread overview]
Message-ID: <20160724200102.GB17624@breton.holly.idiocy.org> (raw)
In-Reply-To: <20160724192819.GA17624@breton.holly.idiocy.org>
On Sun, Jul 24, 2016 at 08:28:19PM +0100, Alan Third wrote:
> I think it would make more sense to only check for base64_p when
> HAVE_LONG_FILE_NAMES is defined, though. If it’s not defined, it’s
> currently checking it then executing identical code whatever the
> outcome.
>
> Once that’s done we’re only duplicating the code once and I don’t
> know if it’s worth introducing a new function for that.
Actually, there’s no reasonable way to do rewrite this so it doesn’t
appear a total of three times, so the function is probably still
useful.
--
Alan Third
prev parent reply other threads:[~2016-07-24 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 12:44 [PATCH] fileio.c: introduce make_temp_name_buf Alexander Kuleshov
2016-07-24 19:28 ` Alan Third
2016-07-24 20:01 ` Alan Third [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160724200102.GB17624@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=emacs-devel@gnu.org \
--cc=kuleshovmail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.