From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master b765164: ;Partially revert 2649105a Date: Thu, 21 Jul 2016 17:04:45 -0400 Message-ID: <20160721210445.GA2283@holos.localdomain> References: <20160721205319.22541.75336@vcs.savannah.gnu.org> <20160721205320.09141220159@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1469135120 12483 80.91.229.3 (21 Jul 2016 21:05:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Jul 2016 21:05:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 21 23:05:04 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQL9U-0001o9-1R for ged-emacs-devel@m.gmane.org; Thu, 21 Jul 2016 23:05:04 +0200 Original-Received: from localhost ([::1]:43729 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQL9S-0006ZQ-QI for ged-emacs-devel@m.gmane.org; Thu, 21 Jul 2016 17:05:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQL9H-0006XF-55 for emacs-devel@gnu.org; Thu, 21 Jul 2016 17:04:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQL9D-0003YI-CJ for emacs-devel@gnu.org; Thu, 21 Jul 2016 17:04:50 -0400 Original-Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:34725) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQL9D-0003YC-84 for emacs-devel@gnu.org; Thu, 21 Jul 2016 17:04:47 -0400 Original-Received: by mail-qt0-x242.google.com with SMTP id c52so4323343qte.1 for ; Thu, 21 Jul 2016 14:04:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mGBvViK9MSrkEoApLpiFdmMZ5GVoClE5B4sIh0QVqWM=; b=Uqmk0bJhRqKDV5brUdfZxHytoX6jI/NwLhm9fxJbRtZSGtheNuljqsCHovKa3C9Ak3 0zSitvEDCY11PtXDA66OcUIWXZAX8/Wnzbq5dmrGhYB6Wp8FSys3659DJYRzBSeHcx7V jwAi32KPck1/mZ6/7eRjGJaGmJ9nVPsmME1g+YCxP+PewRT8wrwpdAGbJ1hXY8X8pUiG MtLjPiLqrCEbMxo0JeKaQJIJd9hjKjw4iFNqn3jHJJE+lT3cnsvIjsSQjDOsZuzPz35V lT+oItgIz6ek9x4wLL0vwKpf+VItTeSD7MWjyRvyGiipCqMgSnJtopugMG8sqERZm4Oj QqPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mGBvViK9MSrkEoApLpiFdmMZ5GVoClE5B4sIh0QVqWM=; b=XWrvxYj5FsqAKK2Dso/71gQ66fm8MkCjt2L/BbiFevziukmvem500ci8mI4Vo4SvsY 50czBLOxInKsYIN8pHjO+GBdJd5KKexvlhE8XtHNgozlPE8UnabTKDPnz8HH3pca2mlk YCsC4BESfe+eQ2DCk307ysQAZmHOgQIHV3oBaOcLLBoesPWpoQyShcNqJ0OYf5581+WT JfXfojurH94xgtzuEjgVjKASkZi7eWdhKp3W/4e5GkXLfuVLUSeYUHvSgppNg+z9EXlc CQVI+igAWCM6zpFNm8ZCpQ3T1ebFkWCqd6VpLCEOUtG41Kr9sh2GgK0awncf2YFRDNyd BQdQ== X-Gm-Message-State: AEkoout0ByDWZL+qizkPajATbQM6A9uvLPV9jSsucOHIxW+a+639cxKAseKxI6ShpKFaNBdA X-Received: by 10.237.60.44 with SMTP id t41mr570209qte.102.1469135086476; Thu, 21 Jul 2016 14:04:46 -0700 (PDT) Original-Received: from holos.localdomain (ip68-100-200-121.dc.dc.cox.net. [68.100.200.121]) by smtp.gmail.com with ESMTPSA id j7sm5404496qkf.11.2016.07.21.14.04.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jul 2016 14:04:45 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 48C6966C35; Thu, 21 Jul 2016 17:04:45 -0400 (EDT) Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2+18 (69bbe4da959f) (2016-07-01) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c0d::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205997 Archived-At: On 21/07/16 at 05:00pm, Stefan Monnier wrote: > > - (add-function :override (local 'prettify-symbols-compose-predicate) > > - #'tex--prettify-symbols-compose-p) > > + (setq-local prettify-symbols-compose-predicate #'tex--prettify-symbols-compose-p) > > Actually, I prefer the add-function version, as can be seen by the fact > that I installed a patch which uses it. And if you look at the commit > history, you'll see that I'm about as close to "maintainer of > tex-mode.el" as there is, so please revert your reversion unless you > have a concrete reason for it (not just "taste" on which we simply > differ and neither can claim that the other one is wrong). Oh, I took https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg00816.html as reason. Will revert. OOC, what patch uses it?