From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: On controlling rectangle-preview Date: Wed, 20 Jul 2016 19:00:47 -0400 Message-ID: <20160720230047.GA18198@holos.localdomain> References: <87wpkhgq5i.fsf@udel.edu> <20160720022539.GA25914@holos.localdomain> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1469055700 19340 80.91.229.3 (20 Jul 2016 23:01:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 20 Jul 2016 23:01:40 +0000 (UTC) Cc: John Wiegley , Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 21 01:01:33 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQ0Ud-00046W-5V for ged-emacs-devel@m.gmane.org; Thu, 21 Jul 2016 01:01:31 +0200 Original-Received: from localhost ([::1]:37431 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ0UZ-0004gy-8l for ged-emacs-devel@m.gmane.org; Wed, 20 Jul 2016 19:01:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ0U3-0004gQ-7v for emacs-devel@gnu.org; Wed, 20 Jul 2016 19:00:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQ0Tz-00072s-3Y for emacs-devel@gnu.org; Wed, 20 Jul 2016 19:00:54 -0400 Original-Received: from mail-qk0-x22b.google.com ([2607:f8b0:400d:c09::22b]:34751) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ0Ty-00072h-Up for emacs-devel@gnu.org; Wed, 20 Jul 2016 19:00:51 -0400 Original-Received: by mail-qk0-x22b.google.com with SMTP id o67so59362392qke.1 for ; Wed, 20 Jul 2016 16:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=feniZ6nNnyqWfGmd1K66h0SUY8oGtSKTXg9ISVMpwTw=; b=ypDFODjZ0NcLKUMbVpse5SFrLWszJ70apkgwePySdJ/3K1YgKRFFFimwSHdtcKLYPD o3n8NKGDb4j/OISvZIjHbbIBVZBWmYOgJINIDuImfFbN7xFZc4Nw7xLaJ+F0LL/QaFNc JMFiIHmlCcJunC646hSJO10lNsZTCgD6LqY+iO7qdJMYGLctFMKkTvzSWbgjDRbVb+Zw samadpBLXmdzPpv8cyyIbTqbUXW4fwc3p5ztfxpEoAefVYyb0AN2qG83BX+qfpxQtwfR V/pXGy/m5tsoT267wAStrSoCAvFxfqv47HF3Ipq6cDlcn4ikMiFte6IxYPHNw95FOwY1 Ufcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=feniZ6nNnyqWfGmd1K66h0SUY8oGtSKTXg9ISVMpwTw=; b=PA58s0V3vTc9uRAblxXUEuGzvU3eqCWnI7Tk8CX65PYxkldw7lfgN7XbfE5GZopMNe 4eAJYwKXDivul26rPrjMuRsVleEk3+e9QcebJW+RJxHGZn/W9ZOCuSL6vlBn3kKLzSyd Bs5Wafh0TCZuhY/1sOgBfjABMPpjiqHHwQytQ0n38amNFvXxRSvFKp9VYkXateVuRDOK /5kZYq7/ocE+0BfjCSiWn1p0X+UOvLzxK0kP2/rY8ZfSzuEipqVWK5fry7M841nK8MMk kXPZPyw0/cBsdQ1fTWUeWltAfRDt1bYGmX9FDGA7EY6NKh2+H6GQbMo2XyuZYAXcMRNB 3g1Q== X-Gm-Message-State: ALyK8tJ9QA4wg6sBNP+oHwWg2MW6hSCJzAZ5C2buyKsCbc0MNvIp011Wjl0rtIMda9Paj1FG X-Received: by 10.55.101.212 with SMTP id z203mr63018434qkb.147.1469055650275; Wed, 20 Jul 2016 16:00:50 -0700 (PDT) Original-Received: from holos.localdomain (ip68-100-200-121.dc.dc.cox.net. [68.100.200.121]) by smtp.gmail.com with ESMTPSA id l22sm2697587qtl.34.2016.07.20.16.00.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jul 2016 16:00:49 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 7DDB466C35; Wed, 20 Jul 2016 19:00:47 -0400 (EDT) Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2+18 (69bbe4da959f) (2016-07-01) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205927 Archived-At: On 20/07/16 at 08:37am, Stefan Monnier wrote: > > To me that seems a little odd (unexpected behaviour), > > Hmm... I can see that. > > > and with an empty minibuffer the default preview is only an M-n away. > > Good point. So I think your patch is OK as is, tho I'm not sure the > custom variable is worth the trouble. Sounds good to me, thanks. This ends up bring very simple--permission to push to emacs-25? diff --git a/lisp/rect.el b/lisp/rect.el index 8803a47..a86d155 100644 --- a/lisp/rect.el +++ b/lisp/rect.el @@ -410,9 +410,6 @@ rectangle-preview (defun rectangle--string-preview () (when rectangle-preview (let ((str (minibuffer-contents))) - (when (equal str "") - (setq str (or (car-safe minibuffer-default) - (if (stringp minibuffer-default) minibuffer-default)))) (when str (setq str (propertize str 'face 'rectangle-preview))) (with-selected-window rectangle--string-preview-window (unless (or (null rectangle--string-preview-state)