all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mark Oteiza <mvoteiza@udel.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: John Wiegley <jwiegley@gmail.com>, Eli Zaretskii <eliz@gnu.org>,
	emacs-devel@gnu.org
Subject: Re: On controlling rectangle-preview
Date: Wed, 20 Jul 2016 19:00:47 -0400	[thread overview]
Message-ID: <20160720230047.GA18198@holos.localdomain> (raw)
In-Reply-To: <jwv1t2oebbs.fsf-monnier+emacs@gnu.org>

On 20/07/16 at 08:37am, Stefan Monnier wrote:
> > To me that seems a little odd (unexpected behaviour),
> 
> Hmm... I can see that.
> 
> > and with an empty minibuffer the default preview is only an M-n away.
> 
> Good point.  So I think your patch is OK as is, tho I'm not sure the
> custom variable is worth the trouble.

Sounds good to me, thanks.

This ends up bring very simple--permission to push to emacs-25?

diff --git a/lisp/rect.el b/lisp/rect.el
index 8803a47..a86d155 100644
--- a/lisp/rect.el
+++ b/lisp/rect.el
@@ -410,9 +410,6 @@ rectangle-preview
 (defun rectangle--string-preview ()
   (when rectangle-preview
     (let ((str (minibuffer-contents)))
-      (when (equal str "")
-        (setq str (or (car-safe minibuffer-default)
-                      (if (stringp minibuffer-default) minibuffer-default))))
       (when str (setq str (propertize str 'face 'rectangle-preview)))
       (with-selected-window rectangle--string-preview-window
         (unless (or (null rectangle--string-preview-state)



  reply	other threads:[~2016-07-20 23:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-19 23:32 On controlling rectangle-preview Mark Oteiza
2016-07-20  1:32 ` Stefan Monnier
2016-07-20  2:25   ` Mark Oteiza
2016-07-20 12:37     ` Stefan Monnier
2016-07-20 23:00       ` Mark Oteiza [this message]
2016-07-21  7:03         ` John Wiegley
2016-07-21 14:28           ` Eli Zaretskii
     [not found]             ` <CAKyxw136-9VCuSJMJ4qW4tunhUqvgpTDtjGjXf7vFxh52=9vdQ@mail.gmail.com>
     [not found]               ` <CAKyxw12WcYDBdEkOc3qMf6MOeC+npxVpVdzVz=hByNUObxw6tw@mail.gmail.com>
2016-07-21 14:54                 ` Mark Oteiza
2016-07-21 15:20                   ` Stefan Monnier
2016-07-21 16:06                   ` Eli Zaretskii
2016-07-21 20:57                     ` Mark Oteiza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160720230047.GA18198@holos.localdomain \
    --to=mvoteiza@udel.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jwiegley@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.