From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#23993: [PATCH] Fix cursor display (bug#23993) Date: Fri, 15 Jul 2016 21:15:55 +0100 Message-ID: <20160715201555.GA93647@breton.holly.idiocy.org> References: <8D3C599E-055D-4118-A00F-ED3612D318C0@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1468630492 30078 80.91.229.3 (16 Jul 2016 00:54:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Jul 2016 00:54:52 +0000 (UTC) Cc: 23993@debbugs.gnu.org To: David Reitter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 16 02:54:37 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bODrH-0007pf-3g for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Jul 2016 02:53:31 +0200 Original-Received: from localhost ([::1]:34794 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO9Xs-0004ha-GW for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Jul 2016 16:17:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO9Xn-0004hQ-5e for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 16:17:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bO9Xi-0004qk-TB for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 16:17:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO9Xi-0004qT-PE for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 16:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bO9Xi-0000O5-GI for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 16:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jul 2016 20:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23993-submit@debbugs.gnu.org id=B23993.14686137631415 (code B ref 23993); Fri, 15 Jul 2016 20:17:02 +0000 Original-Received: (at 23993) by debbugs.gnu.org; 15 Jul 2016 20:16:03 +0000 Original-Received: from localhost ([127.0.0.1]:53316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bO9Wl-0000Mf-Ix for submit@debbugs.gnu.org; Fri, 15 Jul 2016 16:16:03 -0400 Original-Received: from mail-wm0-f65.google.com ([74.125.82.65]:34068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bO9Wk-0000Ly-5B for 23993@debbugs.gnu.org; Fri, 15 Jul 2016 16:16:02 -0400 Original-Received: by mail-wm0-f65.google.com with SMTP id q128so3525406wma.1 for <23993@debbugs.gnu.org>; Fri, 15 Jul 2016 13:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jRH6CHHmcdH44azYuhF5seZ+myC03SXrz6/AwzAgG7s=; b=kgImMdNWvS3wkGuwuBg1Y3nIaicNDZ05ZGZexpnDYD5rw0V4y4prqPsQ+qY5nJ1FPI dAB/qAAHsWRVY7vRCdAataS9EK9t22GY7fXLZp/nWTPsLU45hCagr2IlWXBxQjRvyTU+ TOJ5Ep0QCOTskNDCliWAFkkvNk59ikKPbp245DZizs8uuf/g5H2E8MZtHkVMPmrgZASV dKQY2q/uE3ODj9im/p9/tt9dpVVD1CVXPW+Uf2m5sVdSL3sTLe4X3AZN5JGeAPoMSDZI afCieb6QMlbQToFjeM36G+AZKs/mJ+WHIU+mGNI4bA4AVNUeDFJH19TfwXApZVFIl+7L ZH5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=jRH6CHHmcdH44azYuhF5seZ+myC03SXrz6/AwzAgG7s=; b=BG5q1nEpe4gPRJPzO6MZDNOrGhBJJNVu+CAPSiEtXFgHJog+/obZrMHwdhbHkFZwk8 fEWwo+zDZE1RWZXTm8lNhzoEP47ais7Rlj+L4b+/l+XP0N2YHlxvtVTZ7+TcipTqY/Mc 2ilqpMjQJGHbWljnhXHgrIKpUKpTMPqgrsEBTCf6ipKtjk5Mqdk9tG2NYYQjOe7ZCzAc DRMHdcio1vpExcQNj3C1nnyUSBmXo0LgpPylnTqJjM1feipLjqU8mD1ZCCe1FbRET+uA SzQqprDCQRwyrGy83Lwa0Ts0ahWujO+at729QanTjpsRVbRLs83sr1PSl8JRFh5isEFh loSQ== X-Gm-Message-State: ALyK8tJRNBIpUsGsIqM1NY57ttmApwy7gG/cBYV/bKsWpF2FxNQK4Ngq1BIb5YFov+CXbQ== X-Received: by 10.194.150.204 with SMTP id uk12mr2326284wjb.33.1468613756465; Fri, 15 Jul 2016 13:15:56 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-5cc4-ba14-a0d0-bdac.holly.idiocy.org. [2001:8b0:3f8:8129:5cc4:ba14:a0d0:bdac]) by smtp.gmail.com with ESMTPSA id m201sm2047937wma.11.2016.07.15.13.15.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jul 2016 13:15:55 -0700 (PDT) Content-Disposition: inline In-Reply-To: <8D3C599E-055D-4118-A00F-ED3612D318C0@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121127 Archived-At: * src/xdisp.c (get_phys_cursor_geometry): Fix invalid C operator. --- src/xdisp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xdisp.c b/src/xdisp.c index 14d6f8f..efd5f54 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -2237,7 +2237,7 @@ get_phys_cursor_geometry (struct window *w, struct glyph_row *row, ascent = row->ascent; if (row->ascent < glyph->ascent) { - y =- glyph->ascent - row->ascent; + y -= glyph->ascent - row->ascent; ascent = glyph->ascent; } -- Eli, I just wanted to run this by you because you wrote this code and I'm not sure if that =- is just a typo or it's something I've never seen before. My guess is it's a typo and gcc happily treats it as -=, but clang handles it more like 'y = y - a - b' resulting in odd behaviour on OS X. -- Alan Third