all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: David Reitter <david.reitter@gmail.com>
Cc: 23993@debbugs.gnu.org
Subject: bug#23993: [PATCH] Fix cursor display (bug#23993)
Date: Fri, 15 Jul 2016 21:15:55 +0100	[thread overview]
Message-ID: <20160715201555.GA93647@breton.holly.idiocy.org> (raw)
In-Reply-To: <8D3C599E-055D-4118-A00F-ED3612D318C0@gmail.com>

* src/xdisp.c (get_phys_cursor_geometry): Fix invalid C operator.
---
 src/xdisp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/xdisp.c b/src/xdisp.c
index 14d6f8f..efd5f54 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -2237,7 +2237,7 @@ get_phys_cursor_geometry (struct window *w, struct glyph_row *row,
   ascent = row->ascent;
   if (row->ascent < glyph->ascent)
     {
-      y =- glyph->ascent - row->ascent;
+      y -= glyph->ascent - row->ascent;
       ascent = glyph->ascent;
     }
 
-- 
Eli, I just wanted to run this by you because you wrote this code and
I'm not sure if that =- is just a typo or it's something I've never
seen before. My guess is it's a typo and gcc happily treats it as -=,
but clang handles it more like 'y = y - a - b' resulting in odd
behaviour on OS X.

-- 
Alan Third





  parent reply	other threads:[~2016-07-15 20:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-15 15:11 bug#23993: 25.0.91; cursor vanishes at prompt David Reitter
2016-07-15 16:11 ` Clément Pit--Claudel
2016-07-15 19:01 ` Alan Third
2016-07-15 20:15 ` Alan Third [this message]
2016-07-16  2:50   ` bug#23993: [PATCH] Fix cursor display (bug#23993) David Reitter
2016-07-16  6:54   ` Eli Zaretskii
2016-07-16  9:13   ` Clément Pit--Claudel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160715201555.GA93647@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=23993@debbugs.gnu.org \
    --cc=david.reitter@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.