0644e6f Fix copying properties in 'format' when it produces padding

0644e6f Fix copying properties in 'format' when it produces padding

[Mark Oteiza]

Hi Eli,

Since this change, both eldoc and isearch appear to be broken--haven't
found further effects yet.  In particular, it appears that the face
property at the beginning of the string is being applied to the entire
string indiscriminately.

If I'm understanding Bug#23859 and friends, this behavior suggests that
eldoc and isearch need to be fixed, correct?  I am not certain, so
I wanted to ask.

Re: 0644e6f Fix copying properties in 'format' when it produces padding

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 630 bytes --]

Hi Mark,

A discussion related to this is going on on debbugs:
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23897

On Thu, Jul 7, 2016 at 8:22 PM Mark Oteiza <mvoteiza@udel.edu> wrote:

> Hi Eli,
>
> Since this change, both eldoc and isearch appear to be broken--haven't
> found further effects yet.  In particular, it appears that the face
> property at the beginning of the string is being applied to the entire
> string indiscriminately.
>
> If I'm understanding Bug#23859 and friends, this behavior suggests that
> eldoc and isearch need to be fixed, correct?  I am not certain, so
> I wanted to ask.
>
> --

-- 
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1094 bytes --]

Re: 0644e6f Fix copying properties in 'format' when it produces padding

[Mark Oteiza]

On 08/07/16 at 01:38am, Kaushal Modi wrote:
> Hi Mark,
> 
> A discussion related to this is going on on debbugs:
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23897

Oops, thanks.

Re: 0644e6f Fix copying properties in 'format' when it produces padding

[Eli Zaretskii]

> Date: Thu, 7 Jul 2016 20:21:58 -0400
> From: Mark Oteiza <mvoteiza@udel.edu>
> Cc: emacs-devel@gnu.org
> 
> Since this change, both eldoc and isearch appear to be broken

I didn't see any reports about isearch problems.  What did I miss?

> In particular, it appears that the face property at the beginning of
> the string is being applied to the entire string indiscriminately.

If I understand you correctly, that was not the intent of the change I
made.

> If I'm understanding Bug#23859 and friends, this behavior suggests that
> eldoc and isearch need to be fixed, correct?

I don't know yet.  Perhaps there's need for further changes on the C
level, or it could be some subtle bug in the changes I made there.

So please report the isearch problem to bug#23859, and I will look at
both soon.

Thanks.

Re: 0644e6f Fix copying properties in 'format' when it produces padding

[Eli Zaretskii]

> Date: Fri, 08 Jul 2016 09:30:11 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
> So please report the isearch problem to bug#23859

Sorry, I meant 23897, of course.