From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Is it time to drop ChangeLogs? Date: Thu, 7 Jul 2016 13:57:39 +0000 Message-ID: <20160707135739.GC4192@acm.fritz.box> References: <4hd1rw1ubr.fsf@fencepost.gnu.org> <83vb50wxhv.fsf@gnu.org> <87y49vz4cg.fsf@acer.localhost.com> <87twg2g86g.fsf@lifelogs.com> <20160707124606.GB4192@acm.fritz.box> <87furl4n69.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1467899875 21543 80.91.229.3 (7 Jul 2016 13:57:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 7 Jul 2016 13:57:55 +0000 (UTC) Cc: emacs-devel@gnu.org To: Phillip Lord Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 07 15:57:46 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bL9oH-0004BS-U2 for ged-emacs-devel@m.gmane.org; Thu, 07 Jul 2016 15:57:46 +0200 Original-Received: from localhost ([::1]:40099 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL9oH-0006Zj-53 for ged-emacs-devel@m.gmane.org; Thu, 07 Jul 2016 09:57:45 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL9o4-0006WV-SF for emacs-devel@gnu.org; Thu, 07 Jul 2016 09:57:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bL9o0-000415-NA for emacs-devel@gnu.org; Thu, 07 Jul 2016 09:57:31 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:26309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL9o0-00040p-GI for emacs-devel@gnu.org; Thu, 07 Jul 2016 09:57:28 -0400 Original-Received: (qmail 48530 invoked by uid 3782); 7 Jul 2016 13:57:26 -0000 Original-Received: from acm.muc.de (p4FC468F2.dip0.t-ipconnect.de [79.196.104.242]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 07 Jul 2016 15:57:25 +0200 Original-Received: (qmail 6270 invoked by uid 1000); 7 Jul 2016 13:57:39 -0000 Content-Disposition: inline In-Reply-To: <87furl4n69.fsf@russet.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-Received-From: 193.149.48.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205322 Archived-At: Hello, Phillip. On Thu, Jul 07, 2016 at 02:01:34PM +0100, Phillip Lord wrote: > Alan Mackenzie writes: > > I don't know exactly what is meant by "pull request" and "pull request > > system". I don't think they are established terms. > https://en.wikipedia.org/wiki/Distributed_version_control#Pull_requests > You send an email saying "here are the changes that I want to > incorporate". Thanks. > > The term seems to imply that instead of a contributor pushing a change > > from his machine to a central repository, some specially authorised > > authority would pull the change from the contributor's machine. This > > would seem to imply every contributor needing to set up an scp daemon on > > his local machine, which doesn't feel like a Good Thing. > On *some* machine, yes. That can be their own server, or a hosted git > repository, or a branch on the Emacs git repository. The only one of these usable by me would be the last one. I can foresee this branch would be open to anybody to commit anything, and could quickly fill up with questionable changes. Anybody using this method would need to maintain their own copy of this "pull" branch. This could lead to quite a few logistical problems, could it not? Also, the email containing the patch is not the source for what gets merged? This seems inefficient. > > Please explain "pull request\( system\)?" more precisely. > https://en.wikipedia.org/wiki/List_of_tools_for_code_review > It keeps a list of all the pull requests coming in. They provide things > like inline comments over diffs, threaded conversation, integration with > continuous integration. Many of them, once the PR is complete, will > automate the merge to master. OK. > Phil -- Alan Mackenzie (Nuremberg, Germany).