From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#23785: Emacs 25: "Undo" overdoes things. Date: Fri, 17 Jun 2016 17:45:35 +0000 Message-ID: <20160617174535.GD3316@acm.fritz.box> References: <20160617150245.GB3316@acm.fritz.box> <83r3bvbuu1.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1466187490 1036 80.91.229.3 (17 Jun 2016 18:18:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Jun 2016 18:18:10 +0000 (UTC) Cc: 23785@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 17 20:17:57 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bDyL5-0000Sj-7E for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Jun 2016 20:17:55 +0200 Original-Received: from localhost ([::1]:59641 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDyL4-0007xr-FI for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Jun 2016 14:17:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDxqK-0008T9-9G for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 13:46:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDxqE-00024J-8I for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 13:46:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60366) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDxqE-00024F-4e for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 13:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bDxqE-000348-0M for bug-gnu-emacs@gnu.org; Fri, 17 Jun 2016 13:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jun 2016 17:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23785 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23785-submit@debbugs.gnu.org id=B23785.146618552711737 (code B ref 23785); Fri, 17 Jun 2016 17:46:01 +0000 Original-Received: (at 23785) by debbugs.gnu.org; 17 Jun 2016 17:45:27 +0000 Original-Received: from localhost ([127.0.0.1]:44470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDxpe-00033E-Ol for submit@debbugs.gnu.org; Fri, 17 Jun 2016 13:45:26 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:27370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDxpb-000333-Fx for 23785@debbugs.gnu.org; Fri, 17 Jun 2016 13:45:25 -0400 Original-Received: (qmail 40561 invoked by uid 3782); 17 Jun 2016 17:45:22 -0000 Original-Received: from acm.muc.de (p548C685D.dip0.t-ipconnect.de [84.140.104.93]) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 17 Jun 2016 19:45:20 +0200 Original-Received: (qmail 8145 invoked by uid 1000); 17 Jun 2016 17:45:35 -0000 Content-Disposition: inline In-Reply-To: <83r3bvbuu1.fsf@gnu.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119686 Archived-At: Hello, Eli. On Fri, Jun 17, 2016 at 08:15:18PM +0300, Eli Zaretskii wrote: > > Date: Fri, 17 Jun 2016 15:02:45 +0000 > > From: Alan Mackenzie > > Summary: `undo' is broken in Emacs 25. > > In GNU Emacs 25.0.94.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.18.7) > > of 2016-06-07 built on acm > > Repository revision: 9d5ccebeba0506f7280662630f0ee85a52c8a327 > > Configured using: > > 'configure --with-tiff=no --with-gif=no --with-gpm' > > 1. emacs -Q > > 2. C-x C-f decls-6.cc ; file is attached. > > 3. Move point to BOL 17. > > 4. C-o, and insert the line "Type var = init;". Call this line 16½. > > 5. M-x revert-buffer. > > 6. Move point to "[" on L16, and use C-M-k to delete "[3 * peq]". > > 7. C-_. This restores "[3 * peq]" (correctly) but also reinserts line > > 16½ (which is a bug). > Why does this minor issue deserve to declare 'undo' "broken"? Looks > like an exaggeration to me. I don't think it's all that minor an issue. `undo' can no longer be depended upon to restore a buffer to its unchanged state. I've suffered several similar annoyances with `undo' in the emacs-25 branch. Each buffer changing command is meant to have its own undo boundary (with the exception of self-insert-command and the single character deleting command). And having to undo/redo command sequences by hand is _very_ irritating when testing. I think there's a case to be made for fixing this bug for Emacs 25.1. -- Alan Mackenzie (Nuremberg, Germany).