From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#16856: [PATCH] Prevent cursor from over-drawing the fringe Date: Sat, 21 May 2016 08:35:36 +0100 Message-ID: <20160521073536.GA95517@breton.holly.idiocy.org> References: <20160517211415.GA85076@breton.holly.idiocy.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1463816185 29807 80.91.229.3 (21 May 2016 07:36:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 May 2016 07:36:25 +0000 (UTC) Cc: 16856@debbugs.gnu.org To: Anders Lindgren Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 21 09:36:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b41SJ-0006J0-J3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 May 2016 09:36:15 +0200 Original-Received: from localhost ([::1]:39188 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b41SI-0002pg-IC for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 May 2016 03:36:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b41SC-0002p2-62 for bug-gnu-emacs@gnu.org; Sat, 21 May 2016 03:36:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b41S6-0005wd-BB for bug-gnu-emacs@gnu.org; Sat, 21 May 2016 03:36:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b41S6-0005wZ-6u for bug-gnu-emacs@gnu.org; Sat, 21 May 2016 03:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b41S5-0000k9-Tm for bug-gnu-emacs@gnu.org; Sat, 21 May 2016 03:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 May 2016 07:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16856 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: unreproducible Original-Received: via spool by 16856-submit@debbugs.gnu.org id=B16856.14638161422831 (code B ref 16856); Sat, 21 May 2016 07:36:01 +0000 Original-Received: (at 16856) by debbugs.gnu.org; 21 May 2016 07:35:42 +0000 Original-Received: from localhost ([127.0.0.1]:59506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b41Rm-0000jb-BW for submit@debbugs.gnu.org; Sat, 21 May 2016 03:35:42 -0400 Original-Received: from mail-wm0-f53.google.com ([74.125.82.53]:36654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b41Rl-0000jP-1X for 16856@debbugs.gnu.org; Sat, 21 May 2016 03:35:41 -0400 Original-Received: by mail-wm0-f53.google.com with SMTP id n129so10951458wmn.1 for <16856@debbugs.gnu.org>; Sat, 21 May 2016 00:35:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=12ups4B6AI0O3lZxDWaXyu6PCtzM0OfdAgQ+o73J3qM=; b=JYxHt3hpvl8dzbzD/OzgQR9FgUvzv8PuNC4Y/pGiALpb/hLrt8wKZ6v7pcUzBhTl/9 WBZtyW06YJNQ5d3VRRoVbNeQcW+cmd1ukoPX0GLFW+67F3oVjzSbS68ENQVOcMijmvro Fof1GxErIBlrSZazU3LDUNCmxs+hKLWnHi7HOJ/5TuLCtOSKYfVE50/kwDrf7qch3BkC td+XVZOg8bQNzu5MDdYVPI4Uh8aSiywAtZzDuibCugXZqIAHxam6MNbIcK3ieOgSBP1W dBNNoS3CHp/fenZUugJUzA2wgxRQzXEi2v+jgoAYgwRRKPt7S6VDOroTfmZG4EICPGlm +EHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=12ups4B6AI0O3lZxDWaXyu6PCtzM0OfdAgQ+o73J3qM=; b=fce2X8isZ+cOXp9bkPP3qjrT5nM/9od4Q7VwsF2ruBlUw6TQCxt0frcUu6fbusekjG 52Tg2kgztD/yBe1GOIEEkTzGiBy0pTmBEEyTkk8bLJlE1fyLK0h87hwmAgZxnFc0gmOb Y3k86efwS4cgpVpD1zxQGQPah+GzlwTXW0jQA64eFg6P+mZuOW60HGG/hHVNPXiHWDi9 DjMSeBKqaRQ4Wym3qcjSl8IXNEEj/TpByL54rhiUPBe+Jy+avljj5M3HiDoMtNgDbGZd YWscXxDcCLvsBtGk+Ei3ef/3vPkj7XpTf6/eDmpjwcjv8sUSCZ1fJSzMzG6EPLbu0/AV OT4A== X-Gm-Message-State: AOPr4FX6hTwyzb+tzIkau5i9/cBps8rsLiiYVt3M4mUjds66Qg0IINd4LGf4f6FApbymww== X-Received: by 10.28.7.197 with SMTP id 188mr7707653wmh.101.1463816135314; Sat, 21 May 2016 00:35:35 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-28ae-bb60-ff32-7c2a.holly.idiocy.org. [2001:8b0:3f8:8129:28ae:bb60:ff32:7c2a]) by smtp.gmail.com with ESMTPSA id c185sm1419880wme.9.2016.05.21.00.35.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 May 2016 00:35:34 -0700 (PDT) Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118507 Archived-At: On Fri, May 20, 2016 at 09:33:52PM +0200, Anders Lindgren wrote: > Hi! > > I gave this patch a try. > > It works well, the ns port now behaves like the win32 and gtk+ parts of > Emacs. > > Do you want me to push it to master? If you could, thanks. > Ps. When the text area doesn't partially overlap a column, the cursor can > be drawn in the fringe. It's a bit unfortunate that when it do overlap, > only the part of the cursor in the text area is drawn. A worst case > scenario is that only a single pixel of the cursor is visible. An ideal > solution would be to draw the cursor partially in the text area and > partially in the fringe, but without leaving garbage behind when moved. > However, this is nothing that we can solve here and now as it would require > change to all emacs ports and possibly the core system. Yeah, I was thinking about this but couldn't really see much of a way around it. I checked the gtk+ and windows ports operated this way just to be sure I wasn't introducing another bug as it does seem wrong. :) -- Alan Third