From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#16856: [PATCH] Prevent cursor from over-drawing the fringe Date: Tue, 17 May 2016 22:14:15 +0100 Message-ID: <20160517211415.GA85076@breton.holly.idiocy.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1463536397 18448 80.91.229.3 (18 May 2016 01:53:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 May 2016 01:53:17 +0000 (UTC) Cc: 16856@debbugs.gnu.org To: Anders Lindgren Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 18 03:53:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b2qfd-0000K1-Fg for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 May 2016 03:53:09 +0200 Original-Received: from localhost ([::1]:42077 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2qfc-00068Q-Oh for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 May 2016 21:53:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2qQo-00088y-5z for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 21:37:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2mLS-0003eF-Em for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 17:16:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2mLS-0003eB-Ak for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 17:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b2mLS-0000yD-1N for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 17:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 May 2016 21:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16856 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: unreproducible Original-Received: via spool by 16856-submit@debbugs.gnu.org id=B16856.14635197083664 (code B ref 16856); Tue, 17 May 2016 21:16:01 +0000 Original-Received: (at 16856) by debbugs.gnu.org; 17 May 2016 21:15:08 +0000 Original-Received: from localhost ([127.0.0.1]:56321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2mKa-0000x1-8r for submit@debbugs.gnu.org; Tue, 17 May 2016 17:15:08 -0400 Original-Received: from mail-wm0-f46.google.com ([74.125.82.46]:36214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2mKY-0000wE-1A for 16856@debbugs.gnu.org; Tue, 17 May 2016 17:15:06 -0400 Original-Received: by mail-wm0-f46.google.com with SMTP id n129so157244042wmn.1 for <16856@debbugs.gnu.org>; Tue, 17 May 2016 14:15:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=o8kGXdF0PZlz9pZ7t1fc9/uvXpyHVIejMWiupe1rKsM=; b=jrzosZySFb3mN0vCjd+3SUcIpx6CJqQAZT5hYh7CItLk1J/9sq4d4CLnv6mx3D+px3 +qMNoBBdRmjJtVqiu0hmb5AL+pWXAzh6TX/DBvXUQ1j53N7ovxXggQdSo4xLydX5+NRq oPVJWBz54vpF6WD71h3Dlg7AZQ6HVHP/vx+MUBIEObc+EVvf16hW2y8fV6UuEYI22Pny kCgEo+GL7y1AzUteATM1i82/1RNVoYrML5t/9WUlqLnOpuQy6GrEoe5rsfZsSM/84nSR xHo9d+vxsHf3gLGw0NhweiD7zG117lha9byBcy3mfhE+9wyXLp7gclFmp2/D4QHRi4ly zoKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=o8kGXdF0PZlz9pZ7t1fc9/uvXpyHVIejMWiupe1rKsM=; b=WkISBqHT+ukt3g09TIDXU1L9nYliPR8XDbrgD7PIkEda9AHx+vh1IhZNmg2hSRemMo oWwX/K0qQugKiFchUYRDIQUS0SMsUX3Y19hwjatd7jwC/LUoOG4w53U6PTU8cbv0ZKqV ZJSCOV/dqDHQY5Mun8BpWKeAIUA+AgmtY7WkZJh4oZ15fZKDqf51I+L7qMqQDjD1RpHD 1N9dPnEYscOstwK4ow715+NDkP1v7b+WXoon9LqOPcdvZgm4J6JeDzkkbhbvLCIbvBW7 0NwI4V0sDa7T+a09qVKSQuqduMq8/zNmTASUa6SsP64E9OBCU74mpxHqaGI/yNYQZNs8 WIAw== X-Gm-Message-State: AOPr4FVO3bgsk0lpLVBgg6t7FGa6a7Ds5XJbS6Q3C3xLJbq5mJPWveKI+C6NFOsgiLmgJQ== X-Received: by 10.28.102.8 with SMTP id a8mr3701085wmc.54.1463519700501; Tue, 17 May 2016 14:15:00 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-dcd0-ea5c-d060-789e.holly.idiocy.org. [2001:8b0:3f8:8129:dcd0:ea5c:d060:789e]) by smtp.gmail.com with ESMTPSA id j6sm5068108wjb.29.2016.05.17.14.14.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 May 2016 14:14:59 -0700 (PDT) Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118363 Archived-At: src/nsterm.m (ns_draw_window_cursor): Reduce clip area from ANY_AREA to TEXT_AREA. (bug#16856) --- src/nsterm.m | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/nsterm.m b/src/nsterm.m index 1d48c04..5eb4c8f 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -2873,9 +2873,8 @@ Note that CURSOR_WIDTH is meaningful only for (h)bar cursors. r.size.height = h; r.size.width = w->phys_cursor_width; - /* TODO: only needed in rare cases with last-resort font in HELLO.. - should we do this more efficiently? */ - ns_clip_to_row (w, glyph_row, ANY_AREA, NO); /* do ns_focus(f, &r, 1); if remove */ + /* Prevent the cursor from being drawn outside the text area. */ + ns_clip_to_row (w, glyph_row, TEXT_AREA, NO); /* do ns_focus(f, &r, 1); if remove */ face = FACE_FROM_ID (f, phys_cursor_glyph->face_id); -- I believe this fixes it. -- Alan Third