From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 ccb75d7: Partially revert previous change. Date: Tue, 26 Apr 2016 20:13:05 -0400 Message-ID: <20160427001305.GA17327@holos.localdomain> References: <20160426154539.13857.91834@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1461716014 19030 80.91.229.3 (27 Apr 2016 00:13:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Apr 2016 00:13:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 27 02:13:27 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1avD6c-0002Gk-Sg for ged-emacs-devel@m.gmane.org; Wed, 27 Apr 2016 02:13:27 +0200 Original-Received: from localhost ([::1]:40175 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avD6c-0000uq-4P for ged-emacs-devel@m.gmane.org; Tue, 26 Apr 2016 20:13:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avD6N-0000rx-LJ for emacs-devel@gnu.org; Tue, 26 Apr 2016 20:13:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avD6K-00018n-GF for emacs-devel@gnu.org; Tue, 26 Apr 2016 20:13:11 -0400 Original-Received: from mail-yw0-x242.google.com ([2607:f8b0:4002:c05::242]:33644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avD6K-00018j-9P for emacs-devel@gnu.org; Tue, 26 Apr 2016 20:13:08 -0400 Original-Received: by mail-yw0-x242.google.com with SMTP id o63so6113405ywe.0 for ; Tue, 26 Apr 2016 17:13:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7o/8muLeEdWGwZmbK7YO/9edOF5zb6pPEYQoTaYv8w0=; b=bMkT3wZeNcdhS4Agcw+gTvToTyPqfrshpmITGrkKW9F+0f9SjBuT+k1I/jxi4zOvzN JExrdia/pBlG44UogLsjs71iFh6xHrG/KzWG/5F6J+1awbOhD94AZB97FiZn9dHjlozE ADcNeSlmn9X0fKPNDMSC4nEJUdMHwNdDMuziB+uwz0dRsjWMcKjW/mAdRG2EQOkO5jaP WXzzSXMF5L4aDA1JCazzjpYLyGAuksiD8UBtoQjKbDpJq/KMUpfM/5FsHFTwv9HjnMuH s6uNUliNqFXfhJbw4KZkNAvTlVs39n6M+d5tbXaDoUInprl/VZhpdOu/6LoiIXRsYUFn aeWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7o/8muLeEdWGwZmbK7YO/9edOF5zb6pPEYQoTaYv8w0=; b=RDWAuLpn826sfkE2GiSZTTC8BhVl9aBY7p8HQkoJkarouuIlJumbkzKAtRw798zJcH xpu7kBXB0kaooX9ax3I2TF3vQGkC6e3QnyRFlyI+EFZwfvASzzbbc5mnWZuSN/LHlYoU u7q3wE/cGccdFznuBm90fWV6d4/yOEA98tKGUFpUjcs9XsqjuAwmyp+cePza+1e/dj6F 0rK+cUFAS8cICPuW35+SuJWnF8482QcuCNMP7ztwb941VK6q8qub6NAzV0xPLw9E5XDc 5HmBAt+RBVz/UynNFJLg9UJvlp6czWyD+dHMGBDwGD18sW1m9ScTQEV77KkmjEbL34BF Hc6g== X-Gm-Message-State: AOPr4FUWQhANAI9T8ROgnngyDhDmBO3xXMAKVy4r8ial7uX9Sa8JTBTWndyEQG4yHo5oVlyf X-Received: by 10.129.101.139 with SMTP id z133mr3523360ywb.153.1461715987866; Tue, 26 Apr 2016 17:13:07 -0700 (PDT) Original-Received: from holos.localdomain (pool-96-227-83-242.phlapa.fios.verizon.net. [96.227.83.242]) by smtp.gmail.com with ESMTPSA id l188sm703688ywc.0.2016.04.26.17.13.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Apr 2016 17:13:06 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id DD4616883A; Tue, 26 Apr 2016 20:13:05 -0400 (EDT) Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24+88 (2a73a6e7c6e7) (2015-08-30) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4002:c05::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203370 Archived-At: On 26/04/16 at 08:03pm, Stefan Monnier wrote: > > --- a/lisp/rect.el > > +++ b/lisp/rect.el > > @@ -783,7 +783,7 @@ Ignores `line-move-visual'." > > (if (not old) > > (let ((ol (make-overlay left right))) > > (overlay-put ol 'window window) > > - (overlay-put ol 'face 'rectangle-preview) > > + (overlay-put ol 'face 'region) > > ol) > > (let ((ol (pop old))) > > (move-overlay ol left right (current-buffer)) > > Shouldn't the other uses of `rectangle-preview' in > rectangle--highlight-for-redisplay also be reverted? Probably. Hopefully all fixed now.