From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Request to put three bug fixes into Emacs 25. Date: Tue, 26 Apr 2016 16:52:08 +0000 Message-ID: <20160426165208.GA1791@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1461690054 29969 80.91.229.3 (26 Apr 2016 17:00:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Apr 2016 17:00:54 +0000 (UTC) Cc: Mohammed Sadik , Anders Lindgren , emacs-devel@gnu.org To: John Wiegley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 26 19:00:44 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1av6Lr-0002F9-Rx for ged-emacs-devel@m.gmane.org; Tue, 26 Apr 2016 19:00:43 +0200 Original-Received: from localhost ([::1]:38855 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av6Lr-0007rz-C2 for ged-emacs-devel@m.gmane.org; Tue, 26 Apr 2016 13:00:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av6Lh-0007jx-GI for emacs-devel@gnu.org; Tue, 26 Apr 2016 13:00:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1av6Ld-0001r0-GI for emacs-devel@gnu.org; Tue, 26 Apr 2016 13:00:33 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:60458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av6Ld-0001qb-7h for emacs-devel@gnu.org; Tue, 26 Apr 2016 13:00:29 -0400 Original-Received: (qmail 86147 invoked by uid 3782); 26 Apr 2016 17:00:27 -0000 Original-Received: from acm.muc.de (p548A4B35.dip0.t-ipconnect.de [84.138.75.53]) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 26 Apr 2016 19:00:26 +0200 Original-Received: (qmail 3139 invoked by uid 1000); 26 Apr 2016 16:52:08 -0000 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-Received-From: 193.149.48.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203349 Archived-At: Hello, John. There're three last minute bug fixes I'd like to put into Emacs 25, for the reasons given: 1. Bug #23347 25.0.92; Follow mode scrolling broken -- scrolls only one page Fixing this bug would prevent a change to UI: traditionally in Follow Mode, follow-scroll-up and follow-scroll-down scroll the number of lines equivalent to all the windows displaying the current buffer. In emacs-25, this has changed to only scrolling by the height of the current window. The fix to #23347 restores the traditional functionality of these two functions, introducing new names for what follow-scroll-up/down currently do. The fix has been checked by Anders Lindgren, the submitter of the bug and original author of Follow Mode. 2. Bug #23312 25.0.92; C++: Incorrect indentation of enum values inside a class This was also reported by Anders. The bug is that in C++ Mode, a piece of code like the following, class MyClass { public: enum Id { kAlpha, kBeta // Incorrect indentation. , gets misindented. This happened because a previous enhancement (for enums with explicit type) didn't check the context of a colon sufficiently rigorously. The misindentation happens when "enum" directly follows a protection keyword plus colon (like "public:"). This is going to happen very often, and not fixing this bug would cause a lot of irritation. 3. Bug #23308 25.0.92; angle brackects in #include breaks syntax-ppss (c-mode) This was reported by Mohammed Sadik. Here, in C Mode (etc.), the text properties marking the "parenthesis nature" of the angle brackets in a #include: #include are unbalanced, throwing the syntactic analysis out. This was caused by an unfortunate attempt to fix another bug some while ago (I do not know its number offhand). That other bug has since been completely fixed properly by another change. The fix to bug #23308 is to revert that earlier change, and is a simple 1-line fix. The consequences of not fixing this bug are unknown, but could well be interference with the proper working of some of the newer facilities (like electric-pair-mode) which depend on correct syntactic analysis. So, may I put these fixes into Emacs 25? Thanks! -- Alan Mackenzie (Nuremberg, Germany).