From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#23347: 25.0.92; Follow mode scrolling broken -- scrolls only one page Date: Sun, 24 Apr 2016 14:23:13 +0000 Message-ID: <20160424142313.GB3517@acm.fritz.box> References: <20160424090035.87856.qmail@mail.muc.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1461508045 2115 80.91.229.3 (24 Apr 2016 14:27:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 Apr 2016 14:27:25 +0000 (UTC) Cc: 23347@debbugs.gnu.org To: Anders Lindgren Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 24 16:27:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1auL0D-0005j3-6M for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Apr 2016 16:27:13 +0200 Original-Received: from localhost ([::1]:55633 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auL09-0005Zz-CP for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Apr 2016 10:27:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auL05-0005WG-4n for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 10:27:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auL01-0007gj-Ui for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 10:27:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:32782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auL01-0007gV-Rp for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 10:27:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1auL01-0002yD-Nr for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 10:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Apr 2016 14:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23347 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23347-submit@debbugs.gnu.org id=B23347.146150801411403 (code B ref 23347); Sun, 24 Apr 2016 14:27:01 +0000 Original-Received: (at 23347) by debbugs.gnu.org; 24 Apr 2016 14:26:54 +0000 Original-Received: from localhost ([127.0.0.1]:45119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auKzt-0002xr-OQ for submit@debbugs.gnu.org; Sun, 24 Apr 2016 10:26:53 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:30307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auKzr-0002xi-Pe for 23347@debbugs.gnu.org; Sun, 24 Apr 2016 10:26:52 -0400 Original-Received: (qmail 66434 invoked by uid 3782); 24 Apr 2016 14:26:50 -0000 Original-Received: from acm.muc.de (p548A445C.dip0.t-ipconnect.de [84.138.68.92]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 24 Apr 2016 16:26:48 +0200 Original-Received: (qmail 5700 invoked by uid 1000); 24 Apr 2016 14:23:13 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116756 Archived-At: Hello, Anders. On Sun, Apr 24, 2016 at 02:36:27PM +0200, Anders Lindgren wrote: > Hi! > The normal `scroll-up-command' and `scroll-down-command' (typically bound > to C-v and M-v) can scroll a page at a time, there is no need for a Follow > mode-specific command for that, as the normal Follow mode machinery can > reposition the other windows. (The only difference is that when using C-v > the original window is still selected, whereas with the new > follow-scroll-up command the windows where the original point ends up is > selected.) Indeed. This is a difference important enough to have a command in follow.el which keeps point at the same buffer position it started with. > > I admit it didn't occur to me that there might be use cases other > > than my own. What I think we need here is a customisable option. > > How about `follow-scroll-single-page-flag'? The cleanest default > > for it would probably be nil, since that better observes the > > abstraction that the collection of all visible windows should be > > regarded as a single page. > A cleaner solution would be to define two sets of functions, e.g. > follow-scroll-up-one-page. OK. I'm happy enought with that. I'm not sure that's a good name, though - the "page" bit could easily get confused with the region in a buffer between two ^L characters. Maybe follow-scroll-up-window would be better. What do you think? > Many users might want to use both kind of scrolling (I use both C-v > and C-c . C-v several time every day, depending on how I would like to > scroll the display). With two sets of functions it's easier to do > this. (Also, it's easier to write documentation for a function > designed to do one thing.) For me, C-c . C-v is too tedious to type, so I've just bound and to `follow-scroll-down/up'. I use them many times per day. Another possibility would be to use a C-u prefix argument to indicate N windows as opposed to 1. No, I don't think that's a good idea, either. Anyway, here is what I think we can agree on: 1. `follow-scroll-up/down' should scroll by N windows. 2. There need to be commands in follow.el that scroll by 1 window as is done by the current `follow-scroll-up/down'. You have suggested the name `follow-scroll-up/down-one-page'. I have countered with `follow-scroll-up/down-window'. If we can agree, I'm willing to amend follow.el. I think it's probably too late for this fix to make it into Emacs 25.1, though. > -- Anders -- Alan Mackenzie (Nuremberg, Germany).