all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-25 f99b512: In M-%, avoid making buffer-local binding of text-property-default-nonsticky
Date: Tue, 29 Mar 2016 21:10:30 +0000	[thread overview]
Message-ID: <20160329211030.GC3377@acm.fritz.box> (raw)
In-Reply-To: <jwvwpolcx68.fsf-monnier+emacsdiffs@gnu.org>

Hello, Stefan.

On Tue, Mar 29, 2016 at 08:01:43AM -0400, Stefan Monnier wrote:
> > +              (with-current-buffer (window-buffer (minibuffer-window))
> > +                (let ((text-property-default-nonsticky
> > +                       (cons '(separator . t) text-property-default-nonsticky)))

> Using minibuffer-setup-hook would be a lot less hackish.

But very clumsy.  You can't bind a variable in this sort of hook.  So
you have to save the current value somewhere, set the value you want,
then hope that you can restore the original value afterwards (which you
probably can, but you can't according to the (inadequate) doc string of
minibuffer-exit-hook).

> This assumes that (window-buffer (minibuffer-window)) returns the buffer
> that read-from-minibuffer will use, which is only true in the normal
> case by accident (e.g. it's probably not going to hold in case of
> a recursive minibuffer invocation).

Actually, it doesn't really matter.  As long as the buffer it finds
doesn't have a buffer local binding of text-property-default-nonsticky
(and the minibuffer it will use doesn't, either), then the global value
will get bound, and everything works.

Why does this have to be so difficult?  Why is there no function to
return the (next) minibuffer?  Why is there no facility to bind the
default value of a variable?

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2016-03-29 21:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160329095238.20903.93640@vcs.savannah.gnu.org>
     [not found] ` <E1akqKF-0005Rl-1Q@vcs.savannah.gnu.org>
2016-03-29 12:01   ` [Emacs-diffs] emacs-25 f99b512: In M-%, avoid making buffer-local binding of text-property-default-nonsticky Stefan Monnier
2016-03-29 21:10     ` Alan Mackenzie [this message]
2016-03-29 22:47       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160329211030.GC3377@acm.fritz.box \
    --to=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.