From: Alan Mackenzie <acm@muc.de>
To: Richard Copley <rcopley@gmail.com>
Cc: 23127@debbugs.gnu.org
Subject: bug#23127: 25.0.92; Assertion failure when editing history in query-replace in cc-mode
Date: Tue, 29 Mar 2016 10:03:09 +0000 [thread overview]
Message-ID: <20160329100309.GA3377@acm.fritz.box> (raw)
In-Reply-To: <CAPM58ohqLRq5RePHRDC9YcTC7+Es0=3k33fgnPphgJgm59cnxg@mail.gmail.com>
Hello, Richard.
On Tue, Mar 29, 2016 at 12:24:20AM +0100, Richard Copley wrote:
> Thanks very much Alan.
> I tested your patch and noticed that it fixes query-replace but not
> query-replace-regexp.
Whoops!
> I won't submit a new patch because I don't have the paperwork (sorry),
> but I reckon you just need to move the "(with-current-buffer (...)
> (let (...) ...))" construct outside the "(if regexp-flag ...)". With
> that change it works fine for me.
And it works fine for me, too. Thanks for spotting that. I've
committed the fix (to the emacs-25 branch in the savannah repository),
and I'm closing the bug.
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2016-03-29 10:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 19:51 bug#23127: 25.0.92; Assertion failure when editing history in query-replace in cc-mode Richard Copley
[not found] ` <mailman.8469.1459108386.843.bug-gnu-emacs@gnu.org>
2016-03-28 22:02 ` Alan Mackenzie
2016-03-28 23:24 ` Richard Copley
2016-03-29 10:03 ` Alan Mackenzie [this message]
2016-03-29 10:04 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329100309.GA3377@acm.fritz.box \
--to=acm@muc.de \
--cc=23127@debbugs.gnu.org \
--cc=rcopley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.