From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Make display-time-mode time zone configurable Date: Thu, 18 Feb 2016 21:37:23 -0500 Message-ID: <20160219023723.GB15748@holos> References: <87fuwt8wek.fsf@udel.edu> <56C2A950.3080102@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1455849466 21566 80.91.229.3 (19 Feb 2016 02:37:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Feb 2016 02:37:46 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 19 03:37:35 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aWawo-0001kw-OC for ged-emacs-devel@m.gmane.org; Fri, 19 Feb 2016 03:37:34 +0100 Original-Received: from localhost ([::1]:47639 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWawo-00055W-3G for ged-emacs-devel@m.gmane.org; Thu, 18 Feb 2016 21:37:34 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWawk-00055E-Mk for emacs-devel@gnu.org; Thu, 18 Feb 2016 21:37:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWawf-0006HI-Ly for emacs-devel@gnu.org; Thu, 18 Feb 2016 21:37:30 -0500 Original-Received: from mail-yw0-x235.google.com ([2607:f8b0:4002:c05::235]:34197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWawf-0006HD-Hc for emacs-devel@gnu.org; Thu, 18 Feb 2016 21:37:25 -0500 Original-Received: by mail-yw0-x235.google.com with SMTP id h129so57403951ywb.1 for ; Thu, 18 Feb 2016 18:37:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=4JH7UynTDzyQFdTrdIfBTtH50zN8I4w/mCGC1cvvfPQ=; b=GBsEuWPOp0us51kCeypUn1HOTEoer7loCw2pC9+6xO30TAlEmpaLFISQIaAG4t2Yyf Ez5KR8PY6vALfWQ9dzxXkW0bN9CP9qhOggLoZ0yOH6ie5Stj5lnEIwG37AgcBRkxaXUW pQJRbmDq9YfoaKtPWC2xMQBjD+wdtEWrVNYnfzALqqhvrJvmU+letyhZZ5/PYjkiAMMi NGFufR6DZGu7VhyfcLYjk5ZzF/cJJutqRm9FmAJZYf2TARVh/0kGaTDGhhtQL5m/JoPC +cuJs2YgIJadhcwQMIHR0NwZDHfqCwFu1AuHCkqp3mBG5u+Q+pi000uGGBTDtUpwUBDg 3ZQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=4JH7UynTDzyQFdTrdIfBTtH50zN8I4w/mCGC1cvvfPQ=; b=Us8Dn+L7FRzf6rSJRwhUeYXYM0mZLhx7ccmkfVwKmPXLkbXXqC36tv8gNn395GMgPT a52NJ4B7EzXMAAyC/EsyAmOsl+ojzbUDgS5nqQ10PfvzpRlYC4QVaXHvuvVprR45Qinb nsZ7/ZfuJqAkBsBgp8EfNMLgF8mmr3BZqPsYqwx4PgaYeumdszRGm634W9fsywR8Wr2r AFu99wq2YCCCWrJmpQSxLI8vDUSj/fKDaJeshu2SCghg0EMFZqc3w9uJmUTNLCGoAzXz oiOSDA8RSzg+h6e4b8M0zTl0cjMZ7Bt5/uJmbXQzEEMzpmI72lnEYalyib230gZvksB/ tz6A== X-Gm-Message-State: AG10YOSSxxweSYHJYSXrpoIeqC/s9IwG+q3I00Xcwnaox28mUYMvklKopzZwv/TVgH9LnwTk X-Received: by 10.129.94.69 with SMTP id s66mr7188817ywb.339.1455849444953; Thu, 18 Feb 2016 18:37:24 -0800 (PST) Original-Received: from holos.localdomain (pool-96-227-83-242.phlapa.fios.verizon.net. [96.227.83.242]) by smtp.gmail.com with ESMTPSA id x64sm7018792ywe.31.2016.02.18.18.37.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Feb 2016 18:37:24 -0800 (PST) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 6141D685D4; Thu, 18 Feb 2016 21:37:23 -0500 (EST) Content-Disposition: inline In-Reply-To: <56C2A950.3080102@cs.ucla.edu> User-Agent: Mutt/1.5.24+59 (b55c6a64a07b) (2015-08-30) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4002:c05::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200168 Archived-At: On 15/02/16 at 08:45pm, Paul Eggert wrote: > Mark Oteiza wrote: > > +(defcustom display-time-zone nil > > + "Variable specifying the time zone used in `display-time-string-forms'. > > +See the function `format-time-string' for an explanation of > > +its ZONE variable." > > + :type '(choice (const :tag "Emacs Local Time" nil) > > + (const :tag "Universal Time" t) > > + (const :tag "System Wall Clock Time" wall) > > + (string "Time Zone Rule")) > > + :link '(function-link format-time-string) > > + :group 'display-time) > > This new defcustom seems to duplicate some or all of the existing defcustom > time-stamp-time-zone. Should there be just custom var? or if there should be > two, how should they differ in operation? I suppose ideally there would just be one; however, it appears to me that lots of time-related things are fragmented across Emacs. For instance, setting 24hr clock in display-time has its own defcustom, but to do the same for things that use calendarfu involves setting calendar-time-display-form. This patch just conveniently exposes the ZONE feature in display-time-mode in the same way time-stamp-time-zone does in time-stamp.el. Would it make sense to put a defcustom in (I guess) time.el and have time-stamp.el use it?