From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Make display-time-mode time zone configurable Date: Thu, 18 Feb 2016 21:32:26 -0500 Message-ID: <20160219023226.GA15748@holos> References: <87fuwt8wek.fsf@udel.edu> <56C2A950.3080102@cs.ucla.edu> <87ziv0lo6i.fsf@example.com> <56C35830.4080107@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1455849170 17757 80.91.229.3 (19 Feb 2016 02:32:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Feb 2016 02:32:50 +0000 (UTC) Cc: "W. Greenhouse" , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 19 03:32:43 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aWas7-0005zX-3t for ged-emacs-devel@m.gmane.org; Fri, 19 Feb 2016 03:32:43 +0100 Original-Received: from localhost ([::1]:47608 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWas3-0003bq-5H for ged-emacs-devel@m.gmane.org; Thu, 18 Feb 2016 21:32:39 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWas0-0003bS-8C for emacs-devel@gnu.org; Thu, 18 Feb 2016 21:32:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWarv-0005FM-8V for emacs-devel@gnu.org; Thu, 18 Feb 2016 21:32:36 -0500 Original-Received: from mail-yw0-x229.google.com ([2607:f8b0:4002:c05::229]:32937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWarv-0005Eu-0E for emacs-devel@gnu.org; Thu, 18 Feb 2016 21:32:31 -0500 Original-Received: by mail-yw0-x229.google.com with SMTP id u200so57419844ywf.0 for ; Thu, 18 Feb 2016 18:32:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=kUqEmRQop3dwOeh6EjJvm4KxI93Ro+nZd/H/DwARmnc=; b=iMwfLv38AkI2H70TCCVnRCRgdeKrZOh4O9WhWwQi3H+hxnhi8Ni58kf4rP1GXZEfgh h3oS6o4uNPqgkNKVbSTftAe4cGT0iNAL5gTTlssGouTRa4Dqwp7sK9CJ/sB4nWu1ZotP RQtLZWA8kw2gfcbvMMmggadKDOsF1cYl2zrvwuf/MJCWgukCKvOrQMibUmCJhBkULNvR kr/PWPGGeskBLPMZ2AE17sYaMdKrscobhr+ujBBMm2oWDSrihq5xQLfoRdGd/Y83R8gs ejw8ko12XWg80BHfZGYXT6+jsuicKKlfHudv+MDL8DLv98IGijjvtm8GqedZCHaylEZj 3jng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=kUqEmRQop3dwOeh6EjJvm4KxI93Ro+nZd/H/DwARmnc=; b=EkuNGh2R9z4HxRzZ2B4YNLgqHMIIR7/QOcE3RzhWBw7aUt3JXaMFFN7IUQk1Qk+gUa z1bw0CCQbMfOEOV5eMZeBh/qhSu4quUR8NsaPwP/xRipw7oWa2kYW306+sAxDR2+uLBp YfpvpDfsG3v25GjsCfVIkNX2TK7ZPtcZrXPjBCYjgXNYRuKDqTSBHxijjGCrC6pAIm5b b7L0YMKIsMHQHYeg9j8W8A+hGHcrKkuKU3NGeVKtKdc99x8wcKxRcUrFnedMxnKwSJsf yBquKksgZW/SL5rcYM2p3Yk5swTu1CPztAB01rAkHKtqkWcWq4y9BT11vFyFyUsD2DgA DkYA== X-Gm-Message-State: AG10YOTQILIF+FQjZBPhICx+H4cj2qjhEnuEpofLf9XnuOdouGvAiO5eaaV/3ZSuOYuUiOGH X-Received: by 10.13.241.68 with SMTP id a65mr6965479ywf.324.1455849149621; Thu, 18 Feb 2016 18:32:29 -0800 (PST) Original-Received: from holos.localdomain (pool-96-227-83-242.phlapa.fios.verizon.net. [96.227.83.242]) by smtp.gmail.com with ESMTPSA id b126sm7048243ywd.3.2016.02.18.18.32.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Feb 2016 18:32:27 -0800 (PST) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 0E712685D4; Thu, 18 Feb 2016 21:32:27 -0500 (EST) Content-Disposition: inline In-Reply-To: <56C35830.4080107@cs.ucla.edu> User-Agent: Mutt/1.5.24+59 (b55c6a64a07b) (2015-08-30) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4002:c05::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200167 Archived-At: On 16/02/16 at 09:11am, Paul Eggert wrote: > On 02/16/2016 06:33 AM, W. Greenhouse wrote: > > Also, as far as parts of Emacs that deal with time zones, there's also > > `calendar-time-zone', which uses a totally different format (offset in > > minutes, instead of zoneinfo-style names)! The calendar also seems to > > NIH the handling of daylight saving time. > > Yes, the calendar code predates the new support for time zones at the lower > level, and it suffers because of that. For example, if you had started Emacs > in Cancun last year at 2015-02-01 01:59, its calendar would have been messed > up, because Cancun changed its clocks a minute later (a time zone change, > not a daylight-saving change) and Emacs would have cached the wrong standard > time zone. Eventually we should fix this sort of bug by having the calendar > code use the new lower-level primitives better.... > > > Now that I understand the role of `display-time-string-forms', I can fix > > the problem for myself there without Mark's proposed defcustom, but the > > defcustom raises visibility a lot for others who might have the same > > desired wall-clock configuration as I. > > OK, how about if we wait for others to have problems that cannot be solved > via display-time-string-forms and deal with the issues that come up then. Seeing how display-time-string-forms is a bucket of code, I suspect there are few problems that cannot be solved by changing it. I would like to see this defcustom be made into something more manageable. For instance, assimilating its large pieces into their own functions. I just went for a less intrusive way to implement the ZONE feature.