From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alexander Kuleshov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix compilation erorr when --enable-gcc-warnings passed Date: Sat, 23 Jan 2016 17:57:03 +0600 Message-ID: <20160123115703.GA1446@localhost> References: <1453460084-19646-1-git-send-email-kuleshovmail@gmail.com> <56A2C41C.7030401@cs.ucla.edu> <20160123062857.GA1205@localhost> <56A342F8.1080303@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1453550472 18913 80.91.229.3 (23 Jan 2016 12:01:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 23 Jan 2016 12:01:12 +0000 (UTC) Cc: emacs-devel@gnu.org, Alexander Kuleshov To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 23 13:01:05 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aMwsK-0006u0-Ig for ged-emacs-devel@m.gmane.org; Sat, 23 Jan 2016 13:01:04 +0100 Original-Received: from localhost ([::1]:56990 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMwsJ-0004cy-Qw for ged-emacs-devel@m.gmane.org; Sat, 23 Jan 2016 07:01:03 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMws3-0004cj-P8 for emacs-devel@gnu.org; Sat, 23 Jan 2016 07:00:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMws0-000395-Ir for emacs-devel@gnu.org; Sat, 23 Jan 2016 07:00:47 -0500 Original-Received: from mail-lf0-x22f.google.com ([2a00:1450:4010:c07::22f]:35891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMws0-00038t-A2 for emacs-devel@gnu.org; Sat, 23 Jan 2016 07:00:44 -0500 Original-Received: by mail-lf0-x22f.google.com with SMTP id h129so61907298lfh.3 for ; Sat, 23 Jan 2016 04:00:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=nrruHIKQeB6AvkTiprcUsVIMJPXgiZ1uj+gj3bXNQwI=; b=eHH/e8BmbFNEcGF+S4j3CRwNqC+bvlC0l/mh3EvKTtFY7VNK+CQenVBsrewjtK8aGQ SdCUn//JPxo7FjF5UEgv8kH8cOTneoedOyLbdZgl3umYVZwci0x04N2T2sov0MgfFBaY Xl36ijPvHbaIOUlzCAvvehaX8O77VNQogv4//PPfcBKjexfmF0f2D3xf6l6ATkpN9hfU hPsp0lQEU2hnrth1wM845xpQ9v4tG0ga+KN/X2f5CLY6crlEDylusQPma395rgtSAvvX pMe4NTHbWGvdD2mq55k98ERy+2+1nv1rBTEdUaZFvClxDRcmGKLhjlvH0DzznJZA2hKc /qkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=nrruHIKQeB6AvkTiprcUsVIMJPXgiZ1uj+gj3bXNQwI=; b=Tnk2Ry1OURD1mcInM7xjmlFze3vvlqeYPvEyq2whPiXNAnZXcsblWK4wEwixGmSjpM sPwwnwv54FJ4FwZepBx7p3woZsDSwE4IEsdb7H4zSk8J2bs+FPVk2BSS1DFs01tTkmig kftPgHRd2fgwq8y01TLKg5ohcVTDdv/fqt/mbt3Tdt61ykqkQnjOhilxEhY3ExEJah2U yNNECToVATQqdSO9H5U/C1uyesjpgks13AWNHGEkVzrkq1alq11UQeQ2VOe8xqpTlab7 0UA1NJnaT0KJyrzUfPUsgFuA5AvqP7IM7PMkiI5YWGIq4oScg+2NeLkQqUN/5uYEa3KI 04pQ== X-Gm-Message-State: AG10YOTkbef1ROEmoUIcl/GhLWyg3i2tWQzL4Z+Uj64X0bMeQs9C1dPVLbrOPR1S89dvUg== X-Received: by 10.25.159.9 with SMTP id i9mr3208013lfe.109.1453550443034; Sat, 23 Jan 2016 04:00:43 -0800 (PST) Original-Received: from localhost ([2.133.31.39]) by smtp.gmail.com with ESMTPSA id jm8sm1464672lbc.12.2016.01.23.04.00.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jan 2016 04:00:41 -0800 (PST) Content-Disposition: inline In-Reply-To: <56A342F8.1080303@cs.ucla.edu> X-Operating-System: Linux X-Date: Sat Jan 23 17:47:24 ALMT 2016 User-Agent: Mutt/1.6.0-rc0 ((null)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198633 Archived-At: On 01-23-16, Paul Eggert wrote: > Although there are two lookup_rgb_color implementations, the buggy one is > invoked if USE_CAIRO, and this generates garbage on the screen. I have filed > a bug report; see: > > http://bugs.gnu.org/22442 > > I installed a patch into emacs-25 to replace the compile-time warning with a > run-time crash, if you configure --with-cairo --enable-checking and visit a > .png file. This patch should also fix the other warnings you noticed, albeit > in different ways sometimes. > > Thanks for doing this checking! It found a real bug. I'm long-time emacs user, but just started to dive into its source code. Saw some problems during compilation and decided to send a patch because these minor things like compiler warnings sometimes brings useful results. One question, You sad that you installed a ptach..., but where can I find this patch? I've looked into http://bugs.gnu.org/22442, but can't find it there. Thank you