From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/follow e8937ed: Replace GROUP argument in six window primitives by new functions. Date: Fri, 18 Dec 2015 10:57:49 +0000 Message-ID: <20151218105748.GA3191@acm.fritz.box> References: <20151214165252.26784.43201@vcs.savannah.gnu.org> <20151215131539.GA5018@acm.fritz.box> <8737v3fbqj.fsf@mail.linkov.net> <20151217221445.GD1888@acm.fritz.box> <87zix863aw.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1450436167 7977 80.91.229.3 (18 Dec 2015 10:56:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 18 Dec 2015 10:56:07 +0000 (UTC) To: Juri Linkov , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 18 11:55:57 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a9shY-0006Ir-8T for ged-emacs-devel@m.gmane.org; Fri, 18 Dec 2015 11:55:56 +0100 Original-Received: from localhost ([::1]:59586 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9shX-0001JN-PU for ged-emacs-devel@m.gmane.org; Fri, 18 Dec 2015 05:55:55 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9shK-0001JB-8f for emacs-devel@gnu.org; Fri, 18 Dec 2015 05:55:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9shH-0002Zw-2b for emacs-devel@gnu.org; Fri, 18 Dec 2015 05:55:42 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:18456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9shG-0002YV-Oz for emacs-devel@gnu.org; Fri, 18 Dec 2015 05:55:38 -0500 Original-Received: (qmail 4752 invoked by uid 3782); 18 Dec 2015 10:55:37 -0000 Original-Received: from acm.muc.de (p5B14760D.dip0.t-ipconnect.de [91.20.118.13]) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 18 Dec 2015 11:55:35 +0100 Original-Received: (qmail 18879 invoked by uid 1000); 18 Dec 2015 10:57:49 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-Received-From: 193.149.48.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196466 Archived-At: Hello, John and Juri. On Thu, Dec 17, 2015 at 04:43:12PM -0800, John Wiegley wrote: > >>>>> Juri Linkov writes: > >> I think it would have to be `recenter-window-group', but is > >> `recenter-group' really that ambiguous? People have no problem with > >> `recenter', which, if anything, is even more ambiguous. > > I don't know why `recenter' is not `recenter-window' like other existing > > functions e.g. `reposition-window'. Maybe for historical reasons. But > > `recenter-group' will add more ambiguity: recenter what? what group? > I prefer recenter-window-group. OK, I'm outvoted. :-) I've changed the name in the source and documentation, including changing `recenter-group-function' to `recenter-window-group-function'. The end of the week is fast approaching. I think the time is now ripe for merging this change into the emacs-25 branch. Any more objections? > And maybe we should have `recenter-window' as an alias for `recenter', > just for consistency. Or, maybe not. `recenter' is surely a very old function indeed, and will have grandfather rights to its name. I think introducing the alias (for which there seems no need) would foster confusion. Also, there is `recenter-top-bottom', which for consistency, would also want the alias `recenter-window-top-bottom'. Assuming we have no intention of phasing out the existing names, I don't think we should introduce the aliases. > -- > John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F > http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 -- Alan Mackenzie (Nuremberg, Germany).