From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Please add comments to isearch.el Date: Fri, 11 Dec 2015 12:16:17 +0000 Message-ID: <20151211121617.GA3351@acm.fritz.box> References: <83fuzoojcn.fsf@gnu.org> <83poyd8kta.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1449836084 20039 80.91.229.3 (11 Dec 2015 12:14:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 11 Dec 2015 12:14:44 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 11 13:14:35 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a7Mao-0002cE-T7 for ged-emacs-devel@m.gmane.org; Fri, 11 Dec 2015 13:14:35 +0100 Original-Received: from localhost ([::1]:47139 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7Mao-0006x5-2Y for ged-emacs-devel@m.gmane.org; Fri, 11 Dec 2015 07:14:34 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7MaX-0006wX-1K for emacs-devel@gnu.org; Fri, 11 Dec 2015 07:14:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7MaT-0003DN-RN for emacs-devel@gnu.org; Fri, 11 Dec 2015 07:14:16 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:25015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7MaT-0003CO-IY for emacs-devel@gnu.org; Fri, 11 Dec 2015 07:14:13 -0500 Original-Received: (qmail 32990 invoked by uid 3782); 11 Dec 2015 12:14:11 -0000 Original-Received: from acm.muc.de (p5B14674E.dip0.t-ipconnect.de [91.20.103.78]) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 11 Dec 2015 13:14:10 +0100 Original-Received: (qmail 3782 invoked by uid 1000); 11 Dec 2015 12:16:17 -0000 Content-Disposition: inline In-Reply-To: <83poyd8kta.fsf@gnu.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-Received-From: 193.149.48.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196100 Archived-At: Hello, Eli. On Fri, Dec 11, 2015 at 10:13:21AM +0200, Eli Zaretskii wrote: > Ping! > > Date: Sun, 29 Nov 2015 18:34:16 +0200 > > From: Eli Zaretskii > > Would someone "in the know" please add commentary to isearch.el to > > explain how the various options are passed to the commands defined > > there and affect or not affect them? i'm not sure I count as someone in the know, but .... > > The isearch.el commands are implemented using complex multi-layered > > system of functions and macros that make it very hard to figure out, > > just by looking at the code, which options affect what commands and in > > what ways. About the only way to find that out is by trying each > > command, which is very inefficient. I think it will help make this > > file much more maintainable if commentary were added there explaining > > how all of this works. Thanks in advance. .... perhaps you could be a little more explicit about which "complex multi-layered system of functions and macros" you were thinking about in particular? Was it the one I was complaining of a few days ago, or were you thinking of the state stack (that Drew explicitly mentioned), or something else? -- Alan Mackenzie (Nuremberg, Germany).