all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Please add comments to isearch.el
Date: Fri, 11 Dec 2015 12:16:17 +0000	[thread overview]
Message-ID: <20151211121617.GA3351@acm.fritz.box> (raw)
In-Reply-To: <83poyd8kta.fsf@gnu.org>

Hello, Eli.

On Fri, Dec 11, 2015 at 10:13:21AM +0200, Eli Zaretskii wrote:
> Ping!

> > Date: Sun, 29 Nov 2015 18:34:16 +0200
> > From: Eli Zaretskii <eliz@gnu.org>

> > Would someone "in the know" please add commentary to isearch.el to
> > explain how the various options are passed to the commands defined
> > there and affect or not affect them?

i'm not sure I count as someone in the know, but ....

> > The isearch.el commands are implemented using complex multi-layered
> > system of functions and macros that make it very hard to figure out,
> > just by looking at the code, which options affect what commands and in
> > what ways.  About the only way to find that out is by trying each
> > command, which is very inefficient.  I think it will help make this
> > file much more maintainable if commentary were added there explaining
> > how all of this works.  Thanks in advance.

.... perhaps you could be a little more explicit about which "complex
multi-layered system of functions and macros" you were thinking about in
particular?  Was it the one I was complaining of a few days ago, or were
you thinking of the state stack (that Drew explicitly mentioned), or
something else?

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2015-12-11 12:16 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-29 16:34 Please add comments to isearch.el Eli Zaretskii
2015-12-11  8:13 ` Eli Zaretskii
2015-12-11 12:16   ` Alan Mackenzie [this message]
2015-12-11 12:39     ` Eli Zaretskii
2015-12-11 16:00       ` Artur Malabarba
2015-12-11 16:20         ` Eli Zaretskii
2015-12-11 16:54           ` Artur Malabarba
2015-12-11 16:56             ` Drew Adams
2015-12-11 18:33             ` Eli Zaretskii
2015-12-11 22:59             ` Juri Linkov
2015-12-11 23:24               ` Artur Malabarba
2015-12-11 23:55                 ` Juri Linkov
2015-12-12  7:25               ` Eli Zaretskii
2015-12-12 23:27                 ` Juri Linkov
2015-12-13  1:01                   ` Artur Malabarba
2015-12-14  0:16                     ` Juri Linkov
2015-12-14  1:19                       ` Artur Malabarba
2015-12-14 23:51                         ` Juri Linkov
2015-12-15 10:26                           ` Artur Malabarba
2015-12-16  0:51                             ` Juri Linkov
2015-12-16  9:06                               ` Artur Malabarba
2015-12-17  0:55                                 ` Juri Linkov
2015-12-17 10:19                                   ` Artur Malabarba
2015-12-13  3:38                   ` Eli Zaretskii
     [not found]               ` <<83d1uc6sdq.fsf@gnu.org>
2015-12-12 16:20                 ` Drew Adams
2015-12-12 23:04                   ` John Wiegley
     [not found] <<83fuzoojcn.fsf@gnu.org>
2015-11-29 16:54 ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151211121617.GA3351@acm.fritz.box \
    --to=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.