From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#22101: Emacs-25: inaccuracy in documentation of `mapconcat' in .../lispref/functions.texi Date: Mon, 7 Dec 2015 10:54:58 +0000 Message-ID: <20151207105457.GA1904@acm.fritz.box> References: <20151206102622.GA2113@acm.fritz.box> <83vb8bef6p.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1449485603 29622 80.91.229.3 (7 Dec 2015 10:53:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 7 Dec 2015 10:53:23 +0000 (UTC) Cc: 22101-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 07 11:53:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a5tPr-0007JG-9y for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Dec 2015 11:53:11 +0100 Original-Received: from localhost ([::1]:53769 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5tPq-00032x-Ei for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Dec 2015 05:53:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5tPm-00032f-9z for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2015 05:53:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a5tPj-00014G-2w for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2015 05:53:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5tPi-000148-W5 for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2015 05:53:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a5tPi-0005tb-LP for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2015 05:53:02 -0500 Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Dec 2015 10:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 22101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 22101@debbugs.gnu.org, acm@muc.de, acm@muc.de Original-Received: via spool by 22101-done@debbugs.gnu.org id=D22101.144948557422646 (code D ref 22101); Mon, 07 Dec 2015 10:53:02 +0000 Original-Received: (at 22101-done) by debbugs.gnu.org; 7 Dec 2015 10:52:54 +0000 Original-Received: from localhost ([127.0.0.1]:41345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a5tPZ-0005tB-OV for submit@debbugs.gnu.org; Mon, 07 Dec 2015 05:52:54 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:38059) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a5tPX-0005t3-Mc for 22101-done@debbugs.gnu.org; Mon, 07 Dec 2015 05:52:52 -0500 Original-Received: (qmail 11415 invoked by uid 3782); 7 Dec 2015 10:52:50 -0000 Original-Received: from acm.muc.de (p5B1463E7.dip0.t-ipconnect.de [91.20.99.231]) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 07 Dec 2015 11:52:49 +0100 Original-Received: (qmail 2669 invoked by uid 1000); 7 Dec 2015 10:54:58 -0000 Content-Disposition: inline In-Reply-To: <83vb8bef6p.fsf@gnu.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109703 Archived-At: Hello, Eli. On Sun, Dec 06, 2015 at 06:04:46PM +0200, Eli Zaretskii wrote: > > Date: Sun, 6 Dec 2015 10:26:22 +0000 > > From: Alan Mackenzie [ .... ] > IMO, this errs on the other side: it seems to allow sequences that > will be rejected by mapconcat or by concat that it calls. I suggest > the following alternative wording: > @code{mapconcat} applies @var{function} to each element of > @var{sequence}; the results, which must be sequences of characters > (strings, vectors, or lists), are concatenated into a single string > return value. Between each pair of result sequences, > @code{mapconcat} inserts the characters from @var{separator}, which > also must be a string, or a vector or list of characters. > The argument @var{function} must be a function that can take one > argument and return a sequence of characters: a string, a vector, or > a list. The argument @var{sequence} can be any kind of sequence > except a char-table; that is, a list, a vector, a bool-vector, or a > string. > WDYT? I think it's good. I have just taken the liberty of committing your version, with two changes: I have added @xref{Sequences Arrays Vectors} at the end of the first paragraph. I have changed "return" to "returns" to indicate that the "returning" is mandatory, and not a subclause of the "can" bit. (A small point, but I think it's more correct.) -- Alan Mackenzie (Nuremberg, Germany).