all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: bruce.connor.am@gmail.com
Cc: 22090@debbugs.gnu.org
Subject: bug#22090: Isearch is sluggish and eventually refuses further service	with "[Too many words]".
Date: 4 Dec 2015 19:21:26 -0000	[thread overview]
Message-ID: <20151204192126.73199.qmail@mail.muc.de> (raw)
In-Reply-To: <mailman.1363.1449242229.31583.bug-gnu-emacs@gnu.org>

Hello, Artur.

In article <mailman.1363.1449242229.31583.bug-gnu-emacs@gnu.org> you wrote:
> 2015-12-04 9:23 GMT+00:00 Eli Zaretskii <eliz@gnu.org>:
>>> Date: Fri, 4 Dec 2015 04:20:52 +0000
>>> From: Alan Mackenzie <acm@muc.de>
>>>
>>> With a recent emacs-25 (last update
>>> eaa1fd6dbff8346eb38485de5ebf0fbfacf374d9 from Thursday 2015-12-03):
>>>
>>> emacs -Q
>>> C-c C-f src/xdisp.c
>>> Move point to L30 (paragraph beginning "Updating the display is triggered
>>>   by the Lisp interpreter ...")
>>>
>>> C-s
>>> C-w repeatedly, to yank words onto the search string.
>>>
>>> After ~29 words have been yanked, the response becomes sluggish, pausing
>>> for between 0.5s and 1s before highlighting the "for" at the end of L31.

> Thanks for the report. The source for this (and for a similar bug
> mentioned on a thread in emacs-devel) was the code I had added for
> special case-folding support.
> For now, I've just removed the code. I can think of a way of solving
> this, but it adds some complexity to isearch, which I don't wanna do
> (and I don't think this feature was that important anyway). Here's a
> full copy of the commit message explaining why the bug happens.

> 30f3432 * lisp/character-fold.el: Remove special case-folding support

> (character-fold-to-regexp): Remove special code for
> case-folding.  Char-fold search still respects the
> `case-fold-search' variable (i.e., f matches F).  This only
> removes the code that was added to ensure that f also matched
> all chars that F matched.  For instance, after this commit, f
> no longer matches 𝔽.

> This was necessary because the logic created a regexp with
> 2^(length of the string) redundant paths.  So, when a very
> long string "almost" matched, Emacs took a very long time to
> figure out that it didn't.  This became particularly relevant
> because isearch's lazy-highlight does a search bounded by (1-
> match-end) (which, in most circumstances, is a search that
> almost matches).  A recipe for this can be found in bug#22090.

Would you like any help to sort out these regexps?  I have some expertise
in doing this, having half-written fix-re.el, a program which analyses
and corrects just the sort of thing you're talking about.

-- 
Alan Mackenzie (Nuremberg, Germany).






  parent reply	other threads:[~2015-12-04 19:21 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04  4:20 bug#22090: Isearch is sluggish and eventually refuses further service with "[Too many words]" Alan Mackenzie
2015-12-04  9:23 ` Eli Zaretskii
2015-12-04 15:16   ` Artur Malabarba
2015-12-04 15:23     ` Eli Zaretskii
2015-12-04 16:06       ` Artur Malabarba
2015-12-04 16:27         ` Eli Zaretskii
2015-12-04 16:37           ` Artur Malabarba
2015-12-04 18:48             ` Eli Zaretskii
2015-12-04 19:59               ` Artur Malabarba
2015-12-05  9:19                 ` Eli Zaretskii
2015-12-04 15:49     ` Random832
2015-12-04 16:21       ` Artur Malabarba
2015-12-04 16:37         ` Random832
2015-12-04 16:51           ` Artur Malabarba
2015-12-04 18:24           ` Eli Zaretskii
     [not found] ` <mailman.1363.1449242229.31583.bug-gnu-emacs@gnu.org>
2015-12-04 17:01   ` Alan Mackenzie
2015-12-04 19:21   ` Alan Mackenzie [this message]
2015-12-04 20:08     ` Eli Zaretskii
2015-12-04 20:49     ` Artur Malabarba
2015-12-04 23:00       ` Alan Mackenzie
2015-12-05 17:23         ` Artur Malabarba
2015-12-05 17:32           ` Eli Zaretskii
2015-12-05 18:12             ` Artur Malabarba
2015-12-05 18:34               ` Eli Zaretskii
2015-12-05 18:52           ` Alan Mackenzie
2015-12-06 12:50             ` Artur Malabarba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151204192126.73199.qmail@mail.muc.de \
    --to=acm@muc.de \
    --cc=22090@debbugs.gnu.org \
    --cc=bruce.connor.am@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.