From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#20241: 25.0.50; `setq' with only one argument Date: Wed, 25 Nov 2015 09:41:55 +0000 Message-ID: <20151125094155.GB2007@acm.fritz.box> References: <16400d25-dff1-4bfb-b929-814714f9e20f@default> <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> <20151123193138.GG2004@acm.fritz.box> <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1448444496 28372 80.91.229.3 (25 Nov 2015 09:41:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Nov 2015 09:41:36 +0000 (UTC) Cc: 20241@debbugs.gnu.org, Artur Malabarba To: John Wiegley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 25 10:41:18 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a1WZg-0004rC-QM for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Nov 2015 10:41:17 +0100 Original-Received: from localhost ([::1]:44095 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1WZd-0005hX-Ba for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Nov 2015 04:41:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1WZY-0005es-5D for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2015 04:41:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1WZT-0007Ha-2P for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2015 04:41:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1WZS-0007HS-Vi for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2015 04:41:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a1WZS-0004un-ME for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2015 04:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Nov 2015 09:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20241 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20241-submit@debbugs.gnu.org id=B20241.144844441618812 (code B ref 20241); Wed, 25 Nov 2015 09:41:02 +0000 Original-Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 09:40:16 +0000 Original-Received: from localhost ([127.0.0.1]:52065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1WYi-0004tM-D6 for submit@debbugs.gnu.org; Wed, 25 Nov 2015 04:40:16 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:31221) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1WYO-0004s9-UD for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 04:40:15 -0500 Original-Received: (qmail 72617 invoked by uid 3782); 25 Nov 2015 09:39:51 -0000 Original-Received: from acm.muc.de (p5B146B74.dip0.t-ipconnect.de [91.20.107.116]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 25 Nov 2015 10:39:50 +0100 Original-Received: (qmail 2121 invoked by uid 1000); 25 Nov 2015 09:41:55 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109223 Archived-At: Hello, John. On Tue, Nov 24, 2015 at 05:46:23PM -0800, John Wiegley wrote: > >>>>> Alan Mackenzie writes: > > I favour leaving the situation as it is. However, it is for John to decide. > > If he comes round to the view that an error is too strong, I am willing to > > turn it back into a warning. > I would like it to appear in 25.1. I'm willing to err against caution this > time. It would be stranger to me to have it go from a warning to an error > within 25.x, which then means waiting until 26 for it to be an error. > Now that it's in the release branch, how about we try out some large packages > and see if it's actually a problem? We won't see any problem in our own sources, because all the occurrences here have been expunged. Any problems will be with external libraries (or possibly in *ELPA) which people expect just to download, compile and run. I think that was what Artur is worried about. > Since I can't imagine anyone intentionally using this just to save > themselves from typing "nil", I'd expect people would want to know > that their setq is ill-formed. It might indicate a real problem. Of the five non-error former occurrences, all were very old - the last one was touched by Stefan in 2005 (according to git blame). Some of them, possibly all of them, were indeed deliberate: there was a space left between the variable and the closing paren. Personally, I think there will be very few in external sources, and we are more likely to flag up real errors than break working code. > John -- Alan Mackenzie (Nuremberg, Germany).