From: Alan Mackenzie <acm@muc.de>
To: John Wiegley <jwiegley@gmail.com>
Cc: 20241@debbugs.gnu.org, Artur Malabarba <bruce.connor.am@gmail.com>
Subject: bug#20241: 25.0.50; `setq' with only one argument
Date: Wed, 25 Nov 2015 09:41:55 +0000 [thread overview]
Message-ID: <20151125094155.GB2007@acm.fritz.box> (raw)
In-Reply-To: <m2oaeihmvk.fsf@newartisans.com>
Hello, John.
On Tue, Nov 24, 2015 at 05:46:23PM -0800, John Wiegley wrote:
> >>>>> Alan Mackenzie <acm@muc.de> writes:
> > I favour leaving the situation as it is. However, it is for John to decide.
> > If he comes round to the view that an error is too strong, I am willing to
> > turn it back into a warning.
> I would like it to appear in 25.1. I'm willing to err against caution this
> time. It would be stranger to me to have it go from a warning to an error
> within 25.x, which then means waiting until 26 for it to be an error.
> Now that it's in the release branch, how about we try out some large packages
> and see if it's actually a problem?
We won't see any problem in our own sources, because all the occurrences
here have been expunged. Any problems will be with external libraries
(or possibly in *ELPA) which people expect just to download, compile and
run. I think that was what Artur is worried about.
> Since I can't imagine anyone intentionally using this just to save
> themselves from typing "nil", I'd expect people would want to know
> that their setq is ill-formed. It might indicate a real problem.
Of the five non-error former occurrences, all were very old - the last
one was touched by Stefan in 2005 (according to git blame). Some of
them, possibly all of them, were indeed deliberate: there was a space
left between the variable and the closing paren.
Personally, I think there will be very few in external sources, and we
are more likely to flag up real errors than break working code.
> John
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2015-11-25 9:41 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 14:53 bug#20241: 25.0.50; `setq' with only one argument Drew Adams
2015-04-01 16:41 ` Stefan Monnier
[not found] ` <mailman.3138.1427900048.31049.bug-gnu-emacs@gnu.org>
2015-11-23 14:31 ` Alan Mackenzie
2015-11-23 18:44 ` Glenn Morris
2015-11-23 18:54 ` Glenn Morris
2015-11-23 22:05 ` John Wiegley
2015-11-23 19:31 ` Alan Mackenzie
2015-11-24 11:32 ` Alan Mackenzie
2015-11-24 17:38 ` Glenn Morris
2015-11-24 18:04 ` Alan Mackenzie
2015-11-24 19:26 ` Artur Malabarba
2015-11-24 21:09 ` Alan Mackenzie
2015-11-25 1:46 ` John Wiegley
2015-11-25 9:41 ` Alan Mackenzie [this message]
2015-11-25 10:36 ` Artur Malabarba
2015-11-25 11:07 ` Alan Mackenzie
2015-11-25 11:13 ` Artur Malabarba
2015-11-25 11:28 ` Alan Mackenzie
2015-11-25 15:18 ` Drew Adams
2015-11-25 15:40 ` Alan Mackenzie
2015-11-25 16:27 ` Drew Adams
2015-11-25 17:22 ` Alan Mackenzie
2015-11-25 18:28 ` Drew Adams
2015-11-25 19:06 ` John Wiegley
2015-11-25 19:21 ` John Mastro
2015-11-25 19:22 ` Drew Adams
2015-11-25 19:34 ` Artur Malabarba
2015-11-25 19:40 ` John Wiegley
2015-11-25 20:20 ` Artur Malabarba
2015-11-25 20:37 ` John Wiegley
2015-11-26 11:07 ` Alan Mackenzie
2015-11-25 20:58 ` Alan Mackenzie
2015-11-25 21:19 ` Drew Adams
2015-11-25 21:52 ` John Wiegley
2015-11-26 0:21 ` Johan Bockgård
2015-11-26 8:58 ` Andreas Schwab
2015-11-26 12:06 ` Alan Mackenzie
2015-11-26 16:38 ` Artur Malabarba
2015-11-26 21:19 ` Alan Mackenzie
2015-11-27 0:07 ` Artur Malabarba
2015-11-25 13:11 ` Nicolas Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151125094155.GB2007@acm.fritz.box \
--to=acm@muc.de \
--cc=20241@debbugs.gnu.org \
--cc=bruce.connor.am@gmail.com \
--cc=jwiegley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.