From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#20241: 25.0.50; `setq' with only one argument Date: Tue, 24 Nov 2015 18:04:52 +0000 Message-ID: <20151124180452.GB1840@acm.fritz.box> References: <16400d25-dff1-4bfb-b929-814714f9e20f@default> <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> <20151123193138.GG2004@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1448389102 31369 80.91.229.3 (24 Nov 2015 18:18:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 24 Nov 2015 18:18:22 +0000 (UTC) Cc: 20241@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 24 19:18:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a1IAJ-00055B-Vr for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Nov 2015 19:18:08 +0100 Original-Received: from localhost ([::1]:40562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1IAL-0004cF-AN for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Nov 2015 13:18:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1Hwk-0004iJ-9f for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2015 13:04:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1Hwh-0006RY-1b for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2015 13:04:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1Hwg-0006RN-Sv for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2015 13:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a1Hwg-0004Eo-ER for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2015 13:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Nov 2015 18:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20241 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20241-submit@debbugs.gnu.org id=B20241.144838819116217 (code B ref 20241); Tue, 24 Nov 2015 18:04:02 +0000 Original-Received: (at 20241) by debbugs.gnu.org; 24 Nov 2015 18:03:11 +0000 Original-Received: from localhost ([127.0.0.1]:51627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1Hvr-0004DU-Gr for submit@debbugs.gnu.org; Tue, 24 Nov 2015 13:03:11 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:30782) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1HvX-0004Ci-37 for 20241@debbugs.gnu.org; Tue, 24 Nov 2015 13:03:10 -0500 Original-Received: (qmail 4632 invoked by uid 3782); 24 Nov 2015 18:02:48 -0000 Original-Received: from acm.muc.de (p5B146A6A.dip0.t-ipconnect.de [91.20.106.106]) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 24 Nov 2015 19:02:47 +0100 Original-Received: (qmail 18821 invoked by uid 1000); 24 Nov 2015 18:04:52 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109188 Archived-At: Hello, Glenn. On Tue, Nov 24, 2015 at 12:38:18PM -0500, Glenn Morris wrote: > I'm assuming that any uses of this form were intentional (or even if > not intentional, were doing the right thing), rather than errors. That wasn't the case. There were 5 deliberate uses of `setq' without the nil, there was one error in bytecomp.el, which had the effect of suppressing warnings given out by the byte compiler. > (I have no actual data - do you?) So making such code stop working > overnight seems too harsh to me. I have data, yes, see above. The point is, that error in bytecomp.el could have been anywhere, causing random breakage. I only noticed it by accident. I don't think the value of allowing an implicit, but undocumented, nil at the end of a `setq' outweighs the danger of accidentally setting a variable to nil. There were, after all, only five uses of this "feature" in the entire Emacs code base. And one of these was in .../obsolete. -- Alan Mackenzie (Nuremberg, Germany).