From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#21983: emacs-25: cconv-convert makes invalid transformations on `setq' forms. Date: Sun, 22 Nov 2015 18:10:43 +0000 Message-ID: <20151122181043.GC2332@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1448215762 18043 80.91.229.3 (22 Nov 2015 18:09:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Nov 2015 18:09:22 +0000 (UTC) To: 21983@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 22 19:09:09 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a0Z4W-0006KU-Vk for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Nov 2015 19:09:09 +0100 Original-Received: from localhost ([::1]:56976 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0Z4X-0007FT-5C for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Nov 2015 13:09:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0Z4T-0007EM-QZ for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 13:09:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0Z4Q-0006d6-J0 for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 13:09:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0Z4Q-0006d2-Fn for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 13:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a0Z4Q-0006qs-0a for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 13:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Nov 2015 18:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21983 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.144821573126319 (code B ref -1); Sun, 22 Nov 2015 18:09:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Nov 2015 18:08:51 +0000 Original-Received: from localhost ([127.0.0.1]:48479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0Z4F-0006qQ-1p for submit@debbugs.gnu.org; Sun, 22 Nov 2015 13:08:51 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36996) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0Z4C-0006qI-HD for submit@debbugs.gnu.org; Sun, 22 Nov 2015 13:08:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0Z4B-0006bL-RX for submit@debbugs.gnu.org; Sun, 22 Nov 2015 13:08:48 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:44273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0Z4B-0006bH-Np for submit@debbugs.gnu.org; Sun, 22 Nov 2015 13:08:47 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0Z4A-0007C7-OJ for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 13:08:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0Z47-0006al-IN for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 13:08:46 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:26571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0Z47-0006aX-8r for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 13:08:43 -0500 Original-Received: (qmail 25795 invoked by uid 3782); 22 Nov 2015 18:08:41 -0000 Original-Received: from acm.muc.de (p548A57CB.dip0.t-ipconnect.de [84.138.87.203]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 22 Nov 2015 19:08:40 +0100 Original-Received: (qmail 3958 invoked by uid 1000); 22 Nov 2015 18:10:43 -0000 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109091 Archived-At: Hello, Emacs. It is desirable for the byte compiler to detect `setq' forms with an odd number of arguments. However, when lexical binding is enabled, this is prevented by cconv-convert. This converts a `setq' form into several single `setq's, and crucially, takes the liberty of supplying a nil argument to the last `setq' should no argument have been present. This is a bug. Here's a patch which appears to fix the problem: diff --git a/lisp/emacs-lisp/cconv.el b/lisp/emacs-lisp/cconv.el index efa9a3d..4a3c273 100644 --- a/lisp/emacs-lisp/cconv.el +++ b/lisp/emacs-lisp/cconv.el @@ -477,17 +477,19 @@ cconv-convert (while forms (let* ((sym (pop forms)) (sym-new (or (cdr (assq sym env)) sym)) - (value (cconv-convert (pop forms) env extend))) + (value-in-list + (and forms + (list (cconv-convert (pop forms) env extend))))) (push (pcase sym-new - ((pred symbolp) `(setq ,sym-new ,value)) - (`(car-safe ,iexp) `(setcar ,iexp ,value)) + ((pred symbolp) `(setq ,sym-new ,@value-in-list)) + (`(car-safe ,iexp) `(setcar ,iexp ,@value-in-list)) ;; This "should never happen", but for variables which are ;; mutated+captured+unused, we may end up trying to `setq' ;; on a closed-over variable, so just drop the setq. (_ ;; (byte-compile-report-error ;; (format "Internal error in cconv of (setq %s ..)" ;; sym-new)) - value)) + (car value-in-list))) prognlist))) (if (cdr prognlist) `(progn . ,(nreverse prognlist)) Because cconv-convert is written in pcase rather than elisp, I may have slipped up on some subtlety. Would somebody please check I haven't. Thanks! -- Alan Mackenzie (Nuremberg, Germany).