From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: setq's with missing final arguments. Date: Sun, 22 Nov 2015 14:10:31 +0000 Message-ID: <20151122141031.GB2332@acm.fritz.box> References: <20151122122657.GA2332@acm.fritz.box> <87egfi5h8i.fsf@igel.home> <87h9ke9o6x.fsf@fencepost.gnu.org> <87a8q65gd6.fsf@igel.home> <87d1v29nih.fsf@fencepost.gnu.org> <87610u5f9g.fsf@igel.home> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1448201329 30295 80.91.229.3 (22 Nov 2015 14:08:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Nov 2015 14:08:49 +0000 (UTC) Cc: David Kastrup , emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 22 15:08:41 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a0VJo-0002y7-Id for ged-emacs-devel@m.gmane.org; Sun, 22 Nov 2015 15:08:40 +0100 Original-Received: from localhost ([::1]:56205 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0VJo-0005lA-Jt for ged-emacs-devel@m.gmane.org; Sun, 22 Nov 2015 09:08:40 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0VJk-0005l0-Cs for emacs-devel@gnu.org; Sun, 22 Nov 2015 09:08:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0VJf-0005eI-C2 for emacs-devel@gnu.org; Sun, 22 Nov 2015 09:08:36 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:18071) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0VJf-0005eC-2e for emacs-devel@gnu.org; Sun, 22 Nov 2015 09:08:31 -0500 Original-Received: (qmail 68863 invoked by uid 3782); 22 Nov 2015 14:08:29 -0000 Original-Received: from acm.muc.de (p548A57CB.dip0.t-ipconnect.de [84.138.87.203]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 22 Nov 2015 15:08:28 +0100 Original-Received: (qmail 3019 invoked by uid 1000); 22 Nov 2015 14:10:31 -0000 Content-Disposition: inline In-Reply-To: <87610u5f9g.fsf@igel.home> User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-Received-From: 193.149.48.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195012 Archived-At: Hello, Andreas. On Sun, Nov 22, 2015 at 02:34:51PM +0100, Andreas Schwab wrote: > David Kastrup writes: > > Presumably you mean that this afflicts both byte compiler and > > interpreter. But that's really beside the point and does not magically > > make it a good idea. > The byte-compiler is not for imposing coding style. That is why I proposed issuing a warning, not an error. In the actual case I found, it was indeed an error. > If it is wrong for setq to accept implit nil then it should be changed > in setq and only then in the byte-compiler. I would be happy enough for a missing final argument to setq to be an error. But until that stage is reached, I think issuing a warning is appropriate. But I disagree with you about priorities: it is more important to catch the violations in our compiled code than worry about the interpreted version. > Andreas. > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 > "And now for something completely different." -- Alan Mackenzie (Nuremberg, Germany).