From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#17453: Isearch doesn't work properly with Follow Mode. Date: Tue, 3 Nov 2015 22:11:31 +0000 Message-ID: <20151103221131.GG2258@acm.fritz.box> References: <20151102092853.GA11804@acm.fritz.box> <20151102123512.GB11804@acm.fritz.box> <20151102154445.GD11804@acm.fritz.box> <87h9l46l7o.fsf@mail.linkov.net> <20151103123116.GD2258@acm.fritz.box> <83a8qvw0aq.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1446588686 32020 80.91.229.3 (3 Nov 2015 22:11:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Nov 2015 22:11:26 +0000 (UTC) Cc: 17453@debbugs.gnu.org, Juri Linkov To: Artur Malabarba Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 03 23:11:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZtjnO-0005o1-Mb for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Nov 2015 23:11:14 +0100 Original-Received: from localhost ([::1]:51312 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtjnI-00044y-V4 for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Nov 2015 17:11:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtjnF-00044l-RR for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 17:11:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtjnC-0001bT-KN for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 17:11:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:32997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtjnC-0001bP-Gp for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 17:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZtjnB-0006nJ-KB for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 17:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Nov 2015 22:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17453 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17453-submit@debbugs.gnu.org id=B17453.144658860726053 (code B ref 17453); Tue, 03 Nov 2015 22:11:01 +0000 Original-Received: (at 17453) by debbugs.gnu.org; 3 Nov 2015 22:10:07 +0000 Original-Received: from localhost ([127.0.0.1]:51938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZtjmI-0006m8-JO for submit@debbugs.gnu.org; Tue, 03 Nov 2015 17:10:07 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:44690) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ztjlv-0006lK-U5 for 17453@debbugs.gnu.org; Tue, 03 Nov 2015 17:10:03 -0500 Original-Received: (qmail 71680 invoked by uid 3782); 3 Nov 2015 22:09:41 -0000 Original-Received: from acm.muc.de (p5B14700A.dip0.t-ipconnect.de [91.20.112.10]) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 03 Nov 2015 23:09:40 +0100 Original-Received: (qmail 15080 invoked by uid 1000); 3 Nov 2015 22:11:31 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108398 Archived-At: Hello, Arturn. On Tue, Nov 03, 2015 at 04:18:45PM +0000, Artur Malabarba wrote: > 2015-11-03 15:49 GMT+00:00 Eli Zaretskii : > >> This is complicated. Ideally, the Follow Mode windows should be > >> synchronised in FM's post-command-hook, not isearch's. It is not > >> isearch's job to realign windows. follow-post-command-hook both realigns > >> windows and choses an appropriate window to put point in. We should let > >> it. > > Once again, if some code in Isearch calls the same function that is > > used in follow-post-command-hook, the above is not an issue. > > Moreover, saving some calls to the hook will make Emacs more > > responsive. > I agree with Eli and Juri on this. If there's a solution as simple as > calling a follow-mode function in isearch-post-update-hook, then this > sounds like a no-downside solution. I'm wondering if we're still talking about the same problem. ;-) A simpler solution is _not_ to call a FM function from that Isearch hook. Unless we're talking at cross purposes, there is simply no need. As long as the Isearch command is allowed to go to completion without forcibly redisplaying, FM will re-synchronise the windows (if needed) and select an appropriate window for point, all on its own (in follow-post-command-hook). > Of course it's not isearch's job to realign windows, but that's why > the hook exists: so that other packages can run their own functions > and do their own jobs at that point in time. Good night, and sleep well! -- Alan Mackenzie (Nuremberg, Germany).