From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: bug#17453: Isearch doesn't work properly with Follow Mode. Date: Mon, 2 Nov 2015 12:39:49 +0000 Message-ID: <20151102123949.GC11804@acm.fritz.box> References: <20140509224458.GA4205@acm.acm> <20151029232302.GB3812@acm.fritz.box> <87h9l6627a.fsf@mail.linkov.net> <20151031235651.GE1853@acm.fritz.box> <87bnbddzpk.fsf@mail.linkov.net> <20151102092853.GA11804@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1446467927 18569 80.91.229.3 (2 Nov 2015 12:38:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Nov 2015 12:38:47 +0000 (UTC) Cc: Juri Linkov , 17453@debbugs.gnu.org, Stefan Monnier , emacs-devel To: Artur Malabarba Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 02 13:38:36 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZtENc-0005FN-HE for ged-emacs-devel@m.gmane.org; Mon, 02 Nov 2015 13:38:32 +0100 Original-Received: from localhost ([::1]:41693 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtENR-0004Rj-38 for ged-emacs-devel@m.gmane.org; Mon, 02 Nov 2015 07:38:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtENC-0004Rc-LK for emacs-devel@gnu.org; Mon, 02 Nov 2015 07:38:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtEN9-0000ci-9S for emacs-devel@gnu.org; Mon, 02 Nov 2015 07:38:06 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:19737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtEN8-0000cd-WB for emacs-devel@gnu.org; Mon, 02 Nov 2015 07:38:03 -0500 Original-Received: (qmail 62906 invoked by uid 3782); 2 Nov 2015 12:38:02 -0000 Original-Received: from acm.muc.de (p5B147B71.dip0.t-ipconnect.de [91.20.123.113]) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 02 Nov 2015 13:38:00 +0100 Original-Received: (qmail 13545 invoked by uid 1000); 2 Nov 2015 12:39:49 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-Received-From: 193.149.48.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193107 Archived-At: Hello, Artur. On Mon, Nov 02, 2015 at 12:14:12PM +0000, Artur Malabarba wrote: > >> One way or another, isearch MUST work with the > >> window boundaries of the entire Follow Mode group. > > Maybe I missed part of the issue. I thought you wanted Isearch to > > switch to another window if that window contains the next match > > (instead of scrolling the current window). For that, you only need > > pos-visible-in-window-p, you don't need to mess with boundaries. > I think I see what I'm missing. Lazy-highlighting stops at the end of > the window, so the matches on the second window won't be highlighted > until we switch to it, right? Absolutely! Not forgetting, of course, matches which start near the bottom of one window, and carry on at the top of the next window. -- Alan Mackenzie (Nuremberg, Germany).