From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#17453: Isearch doesn't work properly with Follow Mode. Date: Sun, 1 Nov 2015 11:59:26 +0000 Message-ID: <20151101115926.GA2768__34465.3494692922$1446379162$gmane$org@acm.fritz.box> References: <20140509224458.GA4205@acm.acm> <20151029232302.GB3812@acm.fritz.box> <20151031232538.GC1853@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1446379161 13542 80.91.229.3 (1 Nov 2015 11:59:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 Nov 2015 11:59:21 +0000 (UTC) To: Stefan Monnier , 17453@debbugs.gnu.org, emacs-devel@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 01 12:59:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZsrHx-0003OA-PF for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Nov 2015 12:59:09 +0100 Original-Received: from localhost ([::1]:36553 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsrHw-00059i-Cw for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Nov 2015 06:59:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45257) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsrHt-00059d-An for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2015 06:59:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZsrHq-0004qc-39 for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2015 06:59:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsrHq-0004qY-0Y for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2015 06:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZsrHp-0003pu-JN for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2015 06:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Nov 2015 11:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17453 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17453-submit@debbugs.gnu.org id=B17453.144637908114666 (code B ref 17453); Sun, 01 Nov 2015 11:59:01 +0000 Original-Received: (at 17453) by debbugs.gnu.org; 1 Nov 2015 11:58:01 +0000 Original-Received: from localhost ([127.0.0.1]:47531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZsrGr-0003oP-5X for submit@debbugs.gnu.org; Sun, 01 Nov 2015 06:58:01 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:59770) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZsrGW-0003nv-MM for 17453@debbugs.gnu.org; Sun, 01 Nov 2015 06:57:59 -0500 Original-Received: (qmail 91858 invoked by uid 3782); 1 Nov 2015 11:57:39 -0000 Original-Received: from acm.muc.de (p548A4E61.dip0.t-ipconnect.de [84.138.78.97]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 01 Nov 2015 12:57:38 +0100 Original-Received: (qmail 2867 invoked by uid 1000); 1 Nov 2015 11:59:26 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108259 Archived-At: Hello, John. On Sat, Oct 31, 2015 at 04:41:01PM -0700, John Wiegley wrote: > >>>>> Alan Mackenzie writes: > > What I am proposing now is a solution where any library which needs to > > manipulate things like window positions will be trivially upgradable to > > working with Follow Mode, merely by replacing `window-start' by > > `window*-start', etc. > Ah, I see. How many libraries do you think would need this change? I honestly don't know. At a guess, I'd say several rather than many. As a quick benchmark, there are 127 occurrences of set-window-start in our lisp sources, in 59 files. > Would using window-start become bad practice under this regime? I hadn't actually thought of that. Thinking about set-window-start (rather than simply window-start), there will be lots of places where a mode is explicitly handling its own windows (? speedbar.el, for example), and set-window*-start would be the wrong thing. But there are also surely examples where set-window-start is currently used just to scroll the text to a specific position. Here set-window*-start would be better. > John -- Alan Mackenzie (Nuremberg, Germany).