From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: bug#17453: Isearch doesn't work properly with Follow Mode. Date: Sun, 1 Nov 2015 11:59:26 +0000 Message-ID: <20151101115926.GA2768@acm.fritz.box> References: <20140509224458.GA4205@acm.acm> <20151029232302.GB3812@acm.fritz.box> <20151031232538.GC1853@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1446379089 12710 80.91.229.3 (1 Nov 2015 11:58:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 Nov 2015 11:58:09 +0000 (UTC) To: Stefan Monnier , 17453@debbugs.gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 01 12:58:00 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZsrGp-0002PM-C8 for ged-emacs-devel@m.gmane.org; Sun, 01 Nov 2015 12:57:59 +0100 Original-Received: from localhost ([::1]:36551 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsrGo-0004i0-2G for ged-emacs-devel@m.gmane.org; Sun, 01 Nov 2015 06:57:58 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsrGb-0004hs-26 for emacs-devel@gnu.org; Sun, 01 Nov 2015 06:57:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZsrGX-0004VI-ON for emacs-devel@gnu.org; Sun, 01 Nov 2015 06:57:44 -0500 Original-Received: from mail.muc.de ([193.149.48.3]:59771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsrGX-0004Uw-EU for emacs-devel@gnu.org; Sun, 01 Nov 2015 06:57:41 -0500 Original-Received: (qmail 91890 invoked by uid 3782); 1 Nov 2015 11:57:39 -0000 Original-Received: from acm.muc.de (p548A4E61.dip0.t-ipconnect.de [84.138.78.97]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 01 Nov 2015 12:57:38 +0100 Original-Received: (qmail 2867 invoked by uid 1000); 1 Nov 2015 11:59:26 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-Received-From: 193.149.48.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193058 Archived-At: Hello, John. On Sat, Oct 31, 2015 at 04:41:01PM -0700, John Wiegley wrote: > >>>>> Alan Mackenzie writes: > > What I am proposing now is a solution where any library which needs to > > manipulate things like window positions will be trivially upgradable to > > working with Follow Mode, merely by replacing `window-start' by > > `window*-start', etc. > Ah, I see. How many libraries do you think would need this change? I honestly don't know. At a guess, I'd say several rather than many. As a quick benchmark, there are 127 occurrences of set-window-start in our lisp sources, in 59 files. > Would using window-start become bad practice under this regime? I hadn't actually thought of that. Thinking about set-window-start (rather than simply window-start), there will be lots of places where a mode is explicitly handling its own windows (? speedbar.el, for example), and set-window*-start would be the wrong thing. But there are also surely examples where set-window-start is currently used just to scroll the text to a specific position. Here set-window*-start would be better. > John -- Alan Mackenzie (Nuremberg, Germany).