From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: "... the window start at a meaningless point within a line." Date: Tue, 27 Oct 2015 13:46:25 +0000 Message-ID: <20151027134625.GB2401@acm.fritz.box> References: <83k2qkhxx3.fsf@gnu.org> <20151019104507.GC2438@acm.fritz.box> <83d1wbgm95.fsf@gnu.org> <20151019112425.GD2438@acm.fritz.box> <83a8rfgkqx.fsf@gnu.org> <20151019120222.GE2438@acm.fritz.box> <838u6zghqz.fsf@gnu.org> <20151019131158.GF2438@acm.fritz.box> <8337x7gf91.fsf@gnu.org> <20151019191522.GI2438@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1445953505 6559 80.91.229.3 (27 Oct 2015 13:45:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 27 Oct 2015 13:45:05 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 27 14:44:56 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zr4YZ-0008Pr-12 for ged-emacs-devel@m.gmane.org; Tue, 27 Oct 2015 14:44:55 +0100 Original-Received: from localhost ([::1]:59742 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr4YY-0002TU-HL for ged-emacs-devel@m.gmane.org; Tue, 27 Oct 2015 09:44:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr4YR-0002TM-Ub for emacs-devel@gnu.org; Tue, 27 Oct 2015 09:44:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zr4YN-0000J2-UN for emacs-devel@gnu.org; Tue, 27 Oct 2015 09:44:47 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:20793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr4YN-0000Ig-Ku for emacs-devel@gnu.org; Tue, 27 Oct 2015 09:44:43 -0400 Original-Received: (qmail 93666 invoked by uid 3782); 27 Oct 2015 13:44:41 -0000 Original-Received: from acm.muc.de (p579E86F6.dip0.t-ipconnect.de [87.158.134.246]) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 27 Oct 2015 14:44:40 +0100 Original-Received: (qmail 4097 invoked by uid 1000); 27 Oct 2015 13:46:25 -0000 Content-Disposition: inline In-Reply-To: <20151019191522.GI2438@acm.fritz.box> User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-Received-From: 193.149.48.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192720 Archived-At: Hello, Eli. On Mon, Oct 19, 2015 at 07:15:22PM +0000, Alan Mackenzie wrote: > On Mon, Oct 19, 2015 at 04:27:38PM +0300, Eli Zaretskii wrote: > > > Date: Mon, 19 Oct 2015 13:11:58 +0000 > > > Cc: emacs-devel@gnu.org > > > From: Alan Mackenzie > > > > > I'm only really looking at the problem of getting to the correct > > > > > beginning of line. Moving to a specific column (with a cons argument to > > > > > vertical-motion) seems to be less of a problem. > > > > If that's in a continuation line, you have the same problem: the > > > > display engine and the move_it_* functions count coordinates and > > > > columns from their BOL, not from your "actual" BOLs. > > > That's not what I see. Having set `it' in Fvertical_motion to an > > > iterator based at WS, the column movement remains based on `it', i.e. > > > based on "actual" BOLs. > > When move_it_by_lines returns, you are on the goal line, at zero X > > coordinate. That zero is in "xdisp coordinates". > OK, I see it. There's a "move_by_lines (it, -1)" near the end of > maybe_move_to_exact_bol. Usually, this would be OK, since we'd be > dealing with "common" BOLs rather than "actual" BOLs, but there might be > a borderline case where `it' would need to go up to the last "actual" > BOL. I'll need to look at this. This "move_by_lines (it, -1)" isn't a problem, since the condition for it occurring ensures it is only executed when starting from a "common" BOL later than the first common BOL. -- Alan Mackenzie (Nuremberg, Germany).