From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: (pos-visible-in-window-p t nil t) returns wrong position/is suboptimally documented. Date: Wed, 30 Sep 2015 14:05:59 +0000 Message-ID: <20150930140559.GC6672@acm.fritz.box> References: <20150927104041.GA2401@acm.fritz.box> <8337y0f7es.fsf@gnu.org> <83twqcbcem.fsf@gnu.org> <20150930085611.GA6672@acm.fritz.box> <83lhbob6bs.fsf@gnu.org> <20150930102231.GB6672@acm.fritz.box> <83h9mcauav.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1443682876 25686 80.91.229.3 (1 Oct 2015 07:01:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 1 Oct 2015 07:01:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 01 09:01:09 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZhXrX-0004zT-Vq for ged-emacs-devel@m.gmane.org; Thu, 01 Oct 2015 09:01:08 +0200 Original-Received: from localhost ([::1]:39170 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhXrX-0000PB-EN for ged-emacs-devel@m.gmane.org; Thu, 01 Oct 2015 03:01:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhHzp-0003BV-Ht for emacs-devel@gnu.org; Wed, 30 Sep 2015 10:04:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZhHzl-0007Zq-T6 for emacs-devel@gnu.org; Wed, 30 Sep 2015 10:04:37 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:23188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhHzl-0007Y0-JP for emacs-devel@gnu.org; Wed, 30 Sep 2015 10:04:33 -0400 Original-Received: (qmail 94626 invoked by uid 3782); 30 Sep 2015 14:04:32 -0000 Original-Received: from acm.muc.de (p5B147BA3.dip0.t-ipconnect.de [91.20.123.163]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 30 Sep 2015 16:04:31 +0200 Original-Received: (qmail 17895 invoked by uid 1000); 30 Sep 2015 14:05:59 -0000 Content-Disposition: inline In-Reply-To: <83h9mcauav.fsf@gnu.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-Received-From: 193.149.48.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:190522 Archived-At: Hello, Eli. On Wed, Sep 30, 2015 at 04:52:24PM +0300, Eli Zaretskii wrote: > > Date: Wed, 30 Sep 2015 10:22:31 +0000 > > Cc: emacs-devel@gnu.org > > From: Alan Mackenzie > > > > However 2: I think there's a bug in the functionality, too. If there is > > > > o - a text buffer > > > > o - with no terminating LF on its last line, and > > > > o - that last line is above the window's last line > > > > then (pos-visible-in-window t nil t) returns the coordinates of the last > > > > lines's EOL. This is the case in both a Linux virtual terminal and an X > > > > windows session. > > > It's not a bug. If you think it's important to mention this marginal > > > use case, I can add that, too. > > OK, it's deliberate. It's a touch puzzling, though. I should grep the > > elisp sources to find out what it's for. I do think it should be > > mentioned in the doc, even if only for preventing somebody like me > > raising a spurious bug report in the future. > > How about expressing the piece of documentation as: > > "If POSITION is `t', that means to check the position the first > > visible position of the last visible screen line with text in > > WINDOW; but if the end of the window's buffer is on the window, this > > position is used instead." > I already committed a change to describe that. The doc string now > says > If POS is t, it specifies either the first position displayed on the > last visible screen line in WINDOW, or the end-of-buffer position, > whichever comes first. > and similar text is in the ELisp manual. > OK? Very much OK! Thanks. -- Alan Mackenzie (Nuremberg, Germany).