all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: (pos-visible-in-window-p t nil t) returns wrong position/is suboptimally documented.
Date: Wed, 30 Sep 2015 08:56:11 +0000	[thread overview]
Message-ID: <20150930085611.GA6672@acm.fritz.box> (raw)
In-Reply-To: <83twqcbcem.fsf@gnu.org>

Hello, Eli.

On Wed, Sep 30, 2015 at 10:21:21AM +0300, Eli Zaretskii wrote:
> > Date: Sun, 27 Sep 2015 14:06:35 +0300
> > From: Eli Zaretskii <eliz@gnu.org>
> > Cc: emacs-devel@gnu.org
> > 
> > > Date: Sun, 27 Sep 2015 10:40:41 +0000
> > > From: Alan Mackenzie <acm@muc.de>
> > > 
> > > Which is correct?  The function or the documentation?
> > 
> > The function.  This has always worked like that.

> I've clarified the documentation to match what the function does in
> that case.

> Thanks.

Thank you!

However:

    "If POSITION is `t', that means to check the first visible position
     of the last visible screen line in WINDOW."

doesn't seem quite right.  If the text in the window is scrolled such
that EOB is in the middle of the window, POSITION t gives the
coordinates of the last line containing text, not the last visible
screen line.  How about something like:

    "If POSITION is `t', that means to check the first visible position
    of the last visible screen line in WINDOW which is at or above the
    end of the window's buffer."

?

-------------------------------------------------------------------------

However 2: I think there's a bug in the functionality, too.  If there is
  o - a text buffer
  o - with no terminating LF on its last line, and
  o - that last line is above the window's last line
then (pos-visible-in-window t nil t) returns the coordinates of the last
lines's EOL.  This is the case in both a Linux virtual terminal and an X
windows session.

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2015-09-30  8:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-27 10:40 (pos-visible-in-window-p t nil t) returns wrong position/is suboptimally documented Alan Mackenzie
2015-09-27 11:06 ` Eli Zaretskii
2015-09-30  7:21   ` Eli Zaretskii
2015-09-30  8:56     ` Alan Mackenzie [this message]
2015-09-30  9:32       ` Eli Zaretskii
2015-09-30 10:22         ` Alan Mackenzie
2015-09-30 13:52           ` Eli Zaretskii
2015-09-30 14:05             ` Alan Mackenzie
2015-10-01  7:36           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150930085611.GA6672@acm.fritz.box \
    --to=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.