From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#21465: [PATCH] CC-modes hierarchy Date: Wed, 16 Sep 2015 13:57:12 +0000 Message-ID: <20150916135712.GB3449@acm.fritz.box> References: <20150914193349.13729.qmail@mail.muc.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1442411850 13895 80.91.229.3 (16 Sep 2015 13:57:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Sep 2015 13:57:30 +0000 (UTC) Cc: 21465@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 16 15:57:16 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZcDD1-00084s-2O for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Sep 2015 15:57:15 +0200 Original-Received: from localhost ([::1]:50947 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcDD0-0007Jf-Fl for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Sep 2015 09:57:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcDCv-0007JE-JC for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2015 09:57:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcDCu-0006Ji-IW for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2015 09:57:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcDCp-0006IM-2D; Wed, 16 Sep 2015 09:57:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZcDCo-0005VK-Io; Wed, 16 Sep 2015 09:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Wed, 16 Sep 2015 13:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21465 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch Original-Received: via spool by 21465-submit@debbugs.gnu.org id=B21465.144241176221118 (code B ref 21465); Wed, 16 Sep 2015 13:57:02 +0000 Original-Received: (at 21465) by debbugs.gnu.org; 16 Sep 2015 13:56:02 +0000 Original-Received: from localhost ([127.0.0.1]:34926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZcDBp-0005UV-Tg for submit@debbugs.gnu.org; Wed, 16 Sep 2015 09:56:02 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:29781) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZcDBn-0005UM-D0 for 21465@debbugs.gnu.org; Wed, 16 Sep 2015 09:56:00 -0400 Original-Received: (qmail 45034 invoked by uid 3782); 16 Sep 2015 13:55:57 -0000 Original-Received: from acm.muc.de (p579E9B29.dip0.t-ipconnect.de [87.158.155.41]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 16 Sep 2015 15:55:56 +0200 Original-Received: (qmail 4471 invoked by uid 1000); 16 Sep 2015 13:57:12 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106644 Archived-At: Hello, Stefan. On Mon, Sep 14, 2015 at 09:06:06PM -0400, Stefan Monnier wrote: > > c-after-font-lock-init surely isn't broken. c-after-change is ALWAYS on > > after-change-functions. > No, it's not. Not in my sm-awk-mode which derives from awk-mode. > Or rather, I don't want it there and c-after-font-lock-init forces it > down my throat again after I removed it. > > Without it, CC Mode simply wouldn't function. > It does. It may appear to, but c-after-change does important things like invalidating caches, and preparing the buffer for font locking. Sooner or later, something will go wrong. (Unless you've put in an sm-c-after-change, or something like that.) But you probably know this. This is one of these "please don't report any bugs whilst this is active". > Besides, my patch does not remove c-after-change from > after-change-functions. It just stops c-after-font-lock-init from > re-adding it if someone decided to remove it. The impression should not be given that c-after-change is in any way an optional extra. It's essential to CC Mode. Why do you want to remove it from your setup? > AFAIK c-after-change is never removed from after-change-functions by > accident, so re-adding it blindly is a bug. I don't think so. Anybody advanced/foolish enough to remove it will know how to remove it even after c-after-font-lock-init has inserted it. This isn't something that should be encouraged. Again, why do you want to take it out of your Awk Mode? [ .... ] > Stefan -- Alan Mackenzie (Nuremberg, Germany).